Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): UI for adding a partition #1935

Draft
wants to merge 36 commits into
base: storage-config-ui
Choose a base branch
from
Draft

feat(web): UI for adding a partition #1935

wants to merge 36 commits into from

Conversation

joseivanlopez
Copy link
Contributor

No description provided.

@joseivanlopez joseivanlopez force-pushed the storage-add-partition branch 3 times, most recently from 36d8c61 to 4372ca3 Compare January 28, 2025 12:14
@coveralls
Copy link

coveralls commented Jan 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13030708832

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.488%
Totals Coverage Status
Change from base Build 13005721999: 0.0%
Covered Lines: 19052
Relevant Lines: 26283
💛 - Coveralls

@joseivanlopez joseivanlopez force-pushed the storage-add-partition branch 12 times, most recently from b6db50c to 3494183 Compare January 31, 2025 07:20
@joseivanlopez
web: add query to get a solved model
429bac2
@joseivanlopez
web: use sizes from solved model
c2f8a81 
- Improve usage of useEffect.
- Disable widgets if the mount point is not valid.
dgdavid and others added 20 commits February 3, 2025 09:29
@dgdavid
feat(web): rename SelectToggle and add unit tests
5a21f50
@dgdavid
fix(web): ensure consistent header rendering
4578706
@joseivanlopez
web: ignore value of invalid mount point
6521002
@ancorgs
Revert "web: ignore value of invalid mount point"
806354d 
This reverts commit 6521002.

According to the way we distributed the tasks, that commit was not
intended to be added by jlopez. Removing it allows to correctly
merge (actually cherry-pick) the correct (more general) commit.
@ancorgs
web: Filter out already used mount paths
6d81026
@ancorgs
web: filter out already used partitions
5caf088
@ancorgs
web: Improve partition descriptions
1e5e3f2
@ancorgs
web: Prevent repeating a mount point
d2eb91b
@ancorgs
web: Validate format of size limits
9c73223
@ancorgs
web: Disable fstype and size for invalid mount points
7215dce
@ancorgs
web: Size parsing closer to its Y2Storage counterpart
841e074
@ancorgs
web: Validate relatioship between min and max sizes
ec8e012
@ancorgs
web: Fix several issues with javascript code format
c1351b0
@joseivanlopez
web: move useVolume component to queries file
3ba81b4 
- Also adds small code improvements.
@joseivanlopez
service: add unit tests
7de2d92
@joseivanlopez
service: fix tests
fde47eb 
- Boot partition now requires 1 GiB instead of 500 MiB.
@joseivanlopez
rust: fix format
2e08534
@joseivanlopez
doc: document #SolveConfigModel DBus method
d55a827
@joseivanlopez
web: add useModel hook
cb28ed6
@dgdavid
Merge branch 'storage-config-ui' into storage-add-partition-select-wr…
c213d68 
…apper-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joseivanlopez @coveralls @dgdavid @ancorgs