This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Cordova 9 support #134
Merged
Cordova 9 support #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var platformRoot = path.join(ctx.opts.projectRoot, 'www'); | ||
| var settingsFile = path.join(platformRoot, 'google-services.json'); | ||
|
|
||
| var platformAndroid = 'platforms/android'; | ||
|
|
||
| if (fs.existsSync('platforms/android/app')) { | ||
| if (fs.existsSync('platforms/android/app/src/main')) { |
There was a problem hiding this comment.
I'm confused about this change. If the platforms/android/app/src/main exists we should use 'platforms/android/app' or it should be update also?
There was a problem hiding this comment.
I had some experiences where some plugins creates an "app" folder. In that case, I would not be able to identify whether cordova-android >= 7.x or not.
The condition is only to try to ensure this. Maybe have another way to do it.
danielpassos
approved these changes
May 27, 2019
There was a problem hiding this comment.
I have tested if using 9.0.0 (cordova-lib@9.0.1) and it works like a charm. Thanks for the contribution @pcsantana I really appreciate that!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cordova 9 support! Fixes #132
Verification Steps
The build succeed!
Checklist:
Progress