This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Cordova 9 support #133
Closed
Cordova 9 support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pcsantana Can you rebase it to fix the commits problem? You can run it on your master branch (assuming your git is origin and aerogear is upstream) |
|
I tried as suggested, but the commits history got worse. So, I reset it and committed again. Sorry for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cordova 9 support! Fixes #132
Verification Steps
The build succeed!
Checklist:
Progress
Additional Notes
PS.: Sorry for the mess up the commits history. I commited the solution before I fetch the upstream repo, and I merged it. So it came with older commits. But actually, only the 783c65a commit fixes the issue.