Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Cordova 9 support #134

Merged
merged 1 commit into from
May 27, 2019
Merged

Cordova 9 support #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 29 additions & 30 deletions scripts/androidBeforeInstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,42 @@
module.exports = function(ctx) {
var fs = ctx.requireCordovaModule('fs'),
path = ctx.requireCordovaModule('path'),
var fs = require('fs'),
path = require('path'),
os = require("os"),
readline = require("readline"),
deferral = ctx.requireCordovaModule('q').defer();
readline = require("readline");

var platformRoot = path.join(ctx.opts.projectRoot, 'www');
var settingsFile = path.join(platformRoot, 'google-services.json');

var platformAndroid = 'platforms/android';

if (fs.existsSync('platforms/android/app')) {
if (fs.existsSync('platforms/android/app/src/main')) {
Copy link
Collaborator

@danielpassos danielpassos May 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about this change. If the platforms/android/app/src/main exists we should use 'platforms/android/app' or it should be update also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some experiences where some plugins creates an "app" folder. In that case, I would not be able to identify whether cordova-android >= 7.x or not.
The condition is only to try to ensure this. Maybe have another way to do it.

// cordova-android >= 7.0.0
platformAndroid = 'platforms/android/app';
}

fs.stat(settingsFile, function(err,stats) {
if (err) {
deferral.reject("To use this plugin on android you'll need to add a google-services.json file with the FCM project_info and place that into your www folder");
} else {

fs.createReadStream(settingsFile).pipe(fs.createWriteStream(platformAndroid + '/google-services.json'));

var lineReader = readline.createInterface({
terminal: false,
input : fs.createReadStream(platformAndroid + '/build.gradle')
});
lineReader.on("line", function(line) {
fs.appendFileSync('./build.gradle', line.toString() + os.EOL);
if (/.*\ dependencies \{.*/.test(line)) {
fs.appendFileSync('./build.gradle', '\t\tclasspath "com.google.gms:google-services:3.0.0"' + os.EOL);
fs.appendFileSync('./build.gradle', '\t\tclasspath "com.android.tools.build:gradle:1.2.3+"' + os.EOL);
}
}).on("close", function () {
fs.rename('./build.gradle', platformAndroid + '/build.gradle', deferral.resolve);
});

}
});

return deferral.promise;
return new Promise(function(resolve, reject) {
fs.stat(settingsFile, function(err,stats) {
if (err) {
reject("To use this plugin on android you'll need to add a google-services.json file with the FCM project_info and place that into your www folder");
} else {

fs.createReadStream(settingsFile).pipe(fs.createWriteStream(platformAndroid + '/google-services.json'));

var lineReader = readline.createInterface({
terminal: false,
input : fs.createReadStream(platformAndroid + '/build.gradle')
});
lineReader.on("line", function(line) {
fs.appendFileSync('./build.gradle', line.toString() + os.EOL);
if (/.*\ dependencies \{.*/.test(line)) {
fs.appendFileSync('./build.gradle', '\t\tclasspath "com.google.gms:google-services:3.0.0"' + os.EOL);
fs.appendFileSync('./build.gradle', '\t\tclasspath "com.android.tools.build:gradle:1.2.3+"' + os.EOL);
}
}).on("close", function () {
fs.rename('./build.gradle', platformAndroid + '/build.gradle', resolve);
});

}
});
})
};