This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
[ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix selection drawing after refresh. * Re-select selected node after refresh. * Move Refresh command below divider in context menu since it's not file-specific.
1. MultiRangeInlineEditor.js: simplified conditional, as requested. 2. ScopeManager.js: move function getResolvedPath before its use, to make JSLint happy. 3. QuickEdit/main.js: move functionName null check to calling routine for cleanliness. Things not yet done: 1. QuickEdit/main.js: consolidation of fallback paths. 2. QuickEditHelper: communication between extensions. Short vs. long term solutions.
…g). It should never be missing.
…kEdit:
It now gets set directly as brackets._jsCodeHintsHelper = quickEditHelpe;.
as suggested.
…e item hint list)
…yword hints. Fixes issue adobe#3768
- PanelManager provides APIs to create panels below the editor area. JSLint and Find in Files now use these APIs. - Move editor-holder ht calculations from EditorManager to PanelManager - EditorManager listens to PanelManager for resize notifications. PanelManager listens for window resize (moved from EditorManager) and for Resizer events on all bottom panels. The old EditorManager.resizeEditor() API is still used for edge cases such as status & search bar show/hide, extensions that add fixed top panels, and extensions that don't use Resizer APIs to hide/show panels. - Since PanelManager is listening, Resizer no longer pings EditorManager directly about show/hide/resize. Resizer emits events to notify PanelManager about any panels it may have missed (legacy extensions that add panels via Resizer instead of PanelManager). - Add max-size support to Resizer in anticipation of PanelManager helping to fix bug adobe#2015.
Adds a handleWideResults to hint responses (only active for function signature hints right now). The CodeHintList changes the styling and behavior a bit to suit.
…ther panels resize or overall available `.content` height changes (window resize). Change resizer min/max limits to operate in terms of panel outer height.
…defined by given mode file.
createMockEditor() calls EditorManager.setEditorHolder() to inject mock DOM. * Cleanup: move responsibility for setting editor-holder height from EditorManager into PanelManager (cleaner division of labor).
document, so JS code hints unit tests can share SpecRunnerUtils' mock-Editor creation code instead of duplicating it.
explicitly set margin-top to 0
I added this because somehow the relative path of the WebPlatform logo isn't found.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #3672.
@gruehle i finally managed rebasing.
Learned a lot today.