-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[ARCH] For Review: Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) #3672
Conversation
Flagging for architecture review since this may be a fairly disruptive change, and we also need to think about how Topcoat fits in. Some other potential issues:
|
To @gruehle for [ARCH] tag. Please figure out who to assign to if you decide we should open it. |
@peterflynn i pushed up a few fixes which should return the UI to the normal state. |
@WebsiteDeveloper it looks like this introduced a bug with the shadows in the sidebar (above index.html in both the working set and project panel) as well as the shadow above the project panel ( |
@TuckerWhitehouse thanks for the notice, will look at it. |
@TuckerWhitehouse i pushed a fix which you might want to check out. |
@WebsiteDeveloper Perfect! Thank you :) |
@WebsiteDeveloper thanks for doing this work! @peterflynn this branch does not have the visual problems I was seeing when I tried to update to less 1.3.3. I tried just updating less, which could have been part of the problem. I am seeing a couple more problems:
Everything else I checked looks fine. It would be good to check out some of the popular extensions to make sure they still basically work. |
explicitly set margin-top to 0
I added this because somehow the relative path of the WebPlatform logo isn't found.
@gruehle pushed fixes for the problems you mentioned. |
@WebsiteDeveloper looks much better - thanks! We definitely want this change, but will not be able to pull it in this sprint. Hopefully we can get to it early in the next one, which starts on May 22nd. We'd like to get the jQuery 2.0 update done at the same time. |
@gruehle i wonder if i should put up a version of this rebased on current master and then again look for regressions because as far as i know a few changes to the bootstrap style overrides have been made. |
@WebsiteDeveloper - yes, that would be great. Thanks! |
This is part of the refactorings to upgrade jQuery.
I added for review, because this isn't quite ready for a merge because some UI styles changed. Maybe an Experience Designer could look at it.