Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Debug menu shortcuts are enabled even when Debug menu is hidden #2877

Closed
peterflynn opened this issue Feb 15, 2013 · 2 comments · Fixed by #2888
Closed

Debug menu shortcuts are enabled even when Debug menu is hidden #2877

peterflynn opened this issue Feb 15, 2013 · 2 comments · Fixed by #2888
Assignees
@jasonsanjose
Labels
low priority
Milestone
sprint 21

Comments

@peterflynn
Copy link
Member

  1. Launch Edge Code preview 3
  2. Press F5 or F12

Result: Window reloads or developer tools open

Expected: In preview 2, pressing these shortcuts does nothing

Looks like this was fallout from moving keyboard shortcuts out into a JSON file -- previously, all our core shortcuts were registered as part of the addMenu() call, which is inside an if block. Now, all keyboard shortcuts are always registered.
@TomMalbran TomMalbran mentioned this issue Feb 15, 2013
Merged
@jasonsanjose jasonsanjose mentioned this issue Feb 19, 2013
Closed
@ghost ghost assigned jasonsanjose Feb 20, 2013
@pthiess
Copy link
Contributor

pthiess commented Feb 20, 2013

Reviewed

jasonsanjose added a commit that referenced this issue Feb 21, 2013
@jasonsanjose
Merge pull request #2888 from TomMalbran/tom/fix-issue-2877
4c42b81 
Fix Issue #2877: Debug menu shortcuts are enabled even when Debug menu is hidden
@jasonsanjose
Copy link
Member

Confirmed fixed.

This was referenced Aug 29, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonsanjose jasonsanjose

Labels
low priority
Projects
None yet
Milestone
sprint 21
Development

Successfully merging a pull request may close this issue.

Fix Issue #2877: Debug menu shortcuts are enabled even when Debug menu is hidden
3 participants
@jasonsanjose @peterflynn @pthiess