Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Externalize debug menu as an extension #2902

Closed
jasonsanjose opened this issue Feb 19, 2013 · 2 comments · Fixed by #2942
Closed

Externalize debug menu as an extension #2902

jasonsanjose opened this issue Feb 19, 2013 · 2 comments · Fixed by #2942
Assignees
Milestone

Comments

@jasonsanjose
Copy link
Member

To disable the debug menu in edge code, we use a config flag show_debug_menu in config.json. As a side effect, some debug menu commands still exist, see #2877.

I think a more useful approach would be to refactor the debug commands into a separate extension that we include by default in brackets but we leave out of edge code. This gives us some flexibility for edge code contributors to use the debug commands without hacking their config.

@pthiess
Copy link
Contributor

pthiess commented Feb 20, 2013

Reviewed @jasonsanjose

@jasonsanjose
Copy link
Member Author

Confirmed. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants