[CLOSED] Fix Issue #2877: Debug menu shortcuts are enabled even when Debug menu is hidden

[core-ai-bot]

Issue by TomMalbran
Friday Feb 15, 2013 at 21:36 GMT
Originally opened as adobe/brackets#2888

---

This fixes adobe/brackets#2877 by disabling the "Refresh Brackets" and "Show Developer Tools" commands after they are created using the brackets.config.show_debug_menu value.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/2888/commits

[core-ai-bot]

Comment by peterflynn
Tuesday Feb 19, 2013 at 18:52 GMT

---

For future-proofing, should we do the same thing for all the other debug-menu commands, in case we ever add shortcuts to any of them?

[core-ai-bot]

Comment by jasonsanjose
Tuesday Feb 19, 2013 at 21:37 GMT

---

@peterflynn I have an alternative suggestion as #2902. Would this fix from@TomMalbran as-is be appropriate if the long term goals is to externalize the debug commands?

[core-ai-bot]

Comment by peterflynn
Wednesday Feb 20, 2013 at 22:54 GMT

---

@jasonsanjose I'd imagine if we did #2902 we could eliminate the whole show_debug_menu config flag, along with the code in this patch. And it would definitely eliminate my concern, since this bug couldn't easily regress with other Debug menu items. Seems worth merging this patch in the meantime, though.