Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1965 - Show staged flag in productlist component #519

Merged
merged 10 commits into from
Mar 22, 2021
Merged

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Mar 17, 2021

This PR is pretty similar to #510 but for the productlist component.

The related css changes for Venia are in adobe/aem-cif-guides-venia#118

How Has This Been Tested?

Added unit tests and update the mock GraphQL server used by the Venia ITs.

Screenshots (if appropriate):

Screenshot 2021-03-17 at 14 42 06

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

cjelger added 9 commits March 5, 2021 17:04
- introduce product v2 for 'staged' Magento field
- adapt unit tests for component v2
- ensure the product and variant queries can be extended "multiple times"
- add @SInCE annotation to product interface
- update Magento schema to 2.4.2 EE
- add mandatory "staged" field to the mock JSON responses
- extend unit tests to test both product v1 and v2 components
- fix POM dependencies and remove no longer needed picker implementation
- create productlist v2 component
- update unit tests and GraphQL mock server for Venia ITs
# Conflicts:
#	README.md
#	examples/bundle/src/test/java/com/adobe/cq/commerce/core/examples/servlets/GraphqlServletTest.java
#	examples/bundle/src/test/resources/context/jcr-content.json
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #519 (17f1a4b) into 2.0.0-ee (a0db3e0) will increase coverage by 0.00%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##             2.0.0-ee     #519   +/-   ##
===========================================
  Coverage       87.68%   87.68%           
- Complexity       1244     1254   +10     
===========================================
  Files             234      236    +2     
  Lines            5893     5910   +17     
  Branches          861      862    +1     
===========================================
+ Hits             5167     5182   +15     
- Misses            573      574    +1     
- Partials          153      154    +1     
Flag Coverage Δ Complexity Δ
integration 64.59% <23.80%> (-0.26%) 0.00 <12.00> (ø)
jest 83.33% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 88.07% <90.47%> (+<0.01%) 0.00 <12.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...nternal/models/v1/productlist/ProductListImpl.java 94.80% <ø> (ø) 37.00 <0.00> (ø)
...core/components/models/common/ProductListItem.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nternal/models/v2/productlist/ProductListImpl.java 85.71% <85.71%> (ø) 6.00 <6.00> (?)
...internal/models/v1/common/ProductListItemImpl.java 86.95% <100.00%> (+0.59%) 21.00 <1.00> (+1.00)
...models/v1/productcarousel/ProductCarouselImpl.java 86.15% <100.00%> (+0.21%) 26.00 <0.00> (ø)
...models/v1/relatedproducts/RelatedProductsImpl.java 86.95% <100.00%> (ø) 17.00 <0.00> (ø)
...ore/components/models/productlist/ProductList.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...ts/models/retriever/AbstractCategoryRetriever.java 84.09% <100.00%> (+1.59%) 16.00 <4.00> (+2.00)
.../converters/ProductToProductListItemConverter.java 95.83% <100.00%> (+0.18%) 3.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0db3e0...17f1a4b. Read the comment docs.

@LSantha LSantha removed the To Verify label Mar 22, 2021
@LSantha LSantha merged commit 9e27b92 into 2.0.0-ee Mar 22, 2021
@LSantha LSantha deleted the CIF-1965 branch March 22, 2021 15:44
mhaack pushed a commit that referenced this pull request Jun 4, 2021
* create productlist v2 component
* update unit tests and GraphQL mock server for Venia ITs
mhaack added a commit that referenced this pull request Jun 21, 2021
* CIF-1964 - Show staged flag in product component (#510)

* introduce product v2 for 'staged' Magento field
* adapt unit tests for component v2
* ensure the product and variant queries can be extended "multiple times"
* add @SInCE annotation to product interface
* add readme
* update Magento schema to 2.4.2 EE
* add mandatory "staged" field to the mock JSON responses
* extend unit tests to test both product v1 and v2 components
* fix POM dependencies and remove no longer needed picker implementation

Co-authored-by: Levente Santha <levente@adobe.com>

* CIF-1965 - Show staged flag in productlist component (#519)

* create productlist v2 component
* update unit tests and GraphQL mock server for Venia ITs

* CIF-1964 - Show staged flag in product component (#510)

* introduce product v2 for 'staged' Magento field
* adapt unit tests for component v2
* ensure the product and variant queries can be extended "multiple times"
* add @SInCE annotation to product interface
* add readme
* update Magento schema to 2.4.2 EE
* add mandatory "staged" field to the mock JSON responses
* extend unit tests to test both product v1 and v2 components
* fix POM dependencies and remove no longer needed picker implementation

Co-authored-by: Levente Santha <levente@adobe.com>

* CIF-1965 - Show staged flag in productlist component (#519)

* create productlist v2 component
* update unit tests and GraphQL mock server for Venia ITs

* trivial - update on lastest master branch, fix failing tests

* trivial - update on lastest master branch, fix failing tests

* CIF-1965 - fix test and cleanup test data

* CIF-1965 - fix failing example tests

* CIF-1965 - fix failing ITs

* trivial - fix baseline check

Co-authored-by: Christophe Jelger <jelger@adobe.com>
Co-authored-by: Levente Santha <levente@adobe.com>
herzog31 pushed a commit that referenced this pull request Jun 30, 2021
* CIF-1964 - Show staged flag in product component (#510)

* introduce product v2 for 'staged' Magento field
* adapt unit tests for component v2
* ensure the product and variant queries can be extended "multiple times"
* add @SInCE annotation to product interface
* add readme
* update Magento schema to 2.4.2 EE
* add mandatory "staged" field to the mock JSON responses
* extend unit tests to test both product v1 and v2 components
* fix POM dependencies and remove no longer needed picker implementation

Co-authored-by: Levente Santha <levente@adobe.com>

* CIF-1965 - Show staged flag in productlist component (#519)

* create productlist v2 component
* update unit tests and GraphQL mock server for Venia ITs

* CIF-1964 - Show staged flag in product component (#510)

* introduce product v2 for 'staged' Magento field
* adapt unit tests for component v2
* ensure the product and variant queries can be extended "multiple times"
* add @SInCE annotation to product interface
* add readme
* update Magento schema to 2.4.2 EE
* add mandatory "staged" field to the mock JSON responses
* extend unit tests to test both product v1 and v2 components
* fix POM dependencies and remove no longer needed picker implementation

Co-authored-by: Levente Santha <levente@adobe.com>

* CIF-1965 - Show staged flag in productlist component (#519)

* create productlist v2 component
* update unit tests and GraphQL mock server for Venia ITs

* trivial - update on lastest master branch, fix failing tests

* trivial - update on lastest master branch, fix failing tests

* CIF-1965 - fix test and cleanup test data

* CIF-1965 - fix failing example tests

* CIF-1965 - fix failing ITs

* CIF-2129 - remove "id" support for CIF Core Components

* CIF-2129 - remove "id" support for CIF Core Components

* CIF-2129 - remove "id" support for CIF Core Components - clean up breadcrumb

* CIF-2129 - remove "id" support for CIF Core Components - clean up FeaturedCategoryListImpl

* CIF-2129 - remove "id" support for CIF Core Components - remove id from sample data

* CIF-2129 - remove "id" support for CIF Core Components - cleanup navigation tests

* CIF-2129 - remove "id" support for CIF Core Components - remove id() leftovers from query

* CIF-2129 - remove "id" support for CIF Core Components - use MOCK_CONFIGURATION with uid support for all tests

* CIF-2129 - remove "id" support for CIF Core Components - update GraphqlServlet and fix related unit tests

* CIF-2129 - remove "id" support for CIF Core Components - fix component library and ITs

* CIF-2129 - remove "id" support for CIF Core Components - fix ITs

* CIF-2129 - remove "id" support for CIF Core Components - fix categorycarousel

* CIF-2129 - remove "id" support for CIF Core Components - fix ComponentJSONExporterIT

* CIF-2129 - remove "id" support for CIF Core Components - cleanup tests

* CIF-2129 - remove "id" support for CIF Core Components - improve SearchResultsSetImpl coverage

* CIF-2129 - remove "id" support for CIF Core Components - improve SearchResultsSetImpl coverage

* CIF-2129 - remove commented code

* CIF-2129 - remove "id" support for CIF Core Components - remove ID usage from ContentFragment component

* CIF-2129 - fix Test after rebase on latest master

* CIF-2129 - fix failing ITs still using id

Co-authored-by: Christophe Jelger <jelger@adobe.com>
Co-authored-by: Levente Santha <levente@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants