-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-1965 - Show staged flag in productlist component #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce product v2 for 'staged' Magento field
- adapt unit tests for component v2
- ensure the product and variant queries can be extended "multiple times" - add @SInCE annotation to product interface
- extend unit tests
- add readme
- update Magento schema to 2.4.2 EE - add mandatory "staged" field to the mock JSON responses - extend unit tests to test both product v1 and v2 components - fix POM dependencies and remove no longer needed picker implementation
- create productlist v2 component - update unit tests and GraphQL mock server for Venia ITs
# Conflicts: # README.md # examples/bundle/src/test/java/com/adobe/cq/commerce/core/examples/servlets/GraphqlServletTest.java # examples/bundle/src/test/resources/context/jcr-content.json
9 tasks
- minor fixes
Codecov Report
@@ Coverage Diff @@
## 2.0.0-ee #519 +/- ##
===========================================
Coverage 87.68% 87.68%
- Complexity 1244 1254 +10
===========================================
Files 234 236 +2
Lines 5893 5910 +17
Branches 861 862 +1
===========================================
+ Hits 5167 5182 +15
- Misses 573 574 +1
- Partials 153 154 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
herzog31
approved these changes
Mar 18, 2021
mhaack
pushed a commit
that referenced
this pull request
Jun 4, 2021
* create productlist v2 component * update unit tests and GraphQL mock server for Venia ITs
mhaack
added a commit
that referenced
this pull request
Jun 21, 2021
* CIF-1964 - Show staged flag in product component (#510) * introduce product v2 for 'staged' Magento field * adapt unit tests for component v2 * ensure the product and variant queries can be extended "multiple times" * add @SInCE annotation to product interface * add readme * update Magento schema to 2.4.2 EE * add mandatory "staged" field to the mock JSON responses * extend unit tests to test both product v1 and v2 components * fix POM dependencies and remove no longer needed picker implementation Co-authored-by: Levente Santha <levente@adobe.com> * CIF-1965 - Show staged flag in productlist component (#519) * create productlist v2 component * update unit tests and GraphQL mock server for Venia ITs * CIF-1964 - Show staged flag in product component (#510) * introduce product v2 for 'staged' Magento field * adapt unit tests for component v2 * ensure the product and variant queries can be extended "multiple times" * add @SInCE annotation to product interface * add readme * update Magento schema to 2.4.2 EE * add mandatory "staged" field to the mock JSON responses * extend unit tests to test both product v1 and v2 components * fix POM dependencies and remove no longer needed picker implementation Co-authored-by: Levente Santha <levente@adobe.com> * CIF-1965 - Show staged flag in productlist component (#519) * create productlist v2 component * update unit tests and GraphQL mock server for Venia ITs * trivial - update on lastest master branch, fix failing tests * trivial - update on lastest master branch, fix failing tests * CIF-1965 - fix test and cleanup test data * CIF-1965 - fix failing example tests * CIF-1965 - fix failing ITs * trivial - fix baseline check Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com>
herzog31
pushed a commit
that referenced
this pull request
Jun 30, 2021
* CIF-1964 - Show staged flag in product component (#510) * introduce product v2 for 'staged' Magento field * adapt unit tests for component v2 * ensure the product and variant queries can be extended "multiple times" * add @SInCE annotation to product interface * add readme * update Magento schema to 2.4.2 EE * add mandatory "staged" field to the mock JSON responses * extend unit tests to test both product v1 and v2 components * fix POM dependencies and remove no longer needed picker implementation Co-authored-by: Levente Santha <levente@adobe.com> * CIF-1965 - Show staged flag in productlist component (#519) * create productlist v2 component * update unit tests and GraphQL mock server for Venia ITs * CIF-1964 - Show staged flag in product component (#510) * introduce product v2 for 'staged' Magento field * adapt unit tests for component v2 * ensure the product and variant queries can be extended "multiple times" * add @SInCE annotation to product interface * add readme * update Magento schema to 2.4.2 EE * add mandatory "staged" field to the mock JSON responses * extend unit tests to test both product v1 and v2 components * fix POM dependencies and remove no longer needed picker implementation Co-authored-by: Levente Santha <levente@adobe.com> * CIF-1965 - Show staged flag in productlist component (#519) * create productlist v2 component * update unit tests and GraphQL mock server for Venia ITs * trivial - update on lastest master branch, fix failing tests * trivial - update on lastest master branch, fix failing tests * CIF-1965 - fix test and cleanup test data * CIF-1965 - fix failing example tests * CIF-1965 - fix failing ITs * CIF-2129 - remove "id" support for CIF Core Components * CIF-2129 - remove "id" support for CIF Core Components * CIF-2129 - remove "id" support for CIF Core Components - clean up breadcrumb * CIF-2129 - remove "id" support for CIF Core Components - clean up FeaturedCategoryListImpl * CIF-2129 - remove "id" support for CIF Core Components - remove id from sample data * CIF-2129 - remove "id" support for CIF Core Components - cleanup navigation tests * CIF-2129 - remove "id" support for CIF Core Components - remove id() leftovers from query * CIF-2129 - remove "id" support for CIF Core Components - use MOCK_CONFIGURATION with uid support for all tests * CIF-2129 - remove "id" support for CIF Core Components - update GraphqlServlet and fix related unit tests * CIF-2129 - remove "id" support for CIF Core Components - fix component library and ITs * CIF-2129 - remove "id" support for CIF Core Components - fix ITs * CIF-2129 - remove "id" support for CIF Core Components - fix categorycarousel * CIF-2129 - remove "id" support for CIF Core Components - fix ComponentJSONExporterIT * CIF-2129 - remove "id" support for CIF Core Components - cleanup tests * CIF-2129 - remove "id" support for CIF Core Components - improve SearchResultsSetImpl coverage * CIF-2129 - remove "id" support for CIF Core Components - improve SearchResultsSetImpl coverage * CIF-2129 - remove commented code * CIF-2129 - remove "id" support for CIF Core Components - remove ID usage from ContentFragment component * CIF-2129 - fix Test after rebase on latest master * CIF-2129 - fix failing ITs still using id Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is pretty similar to #510 but for the
productlist
component.The related
css
changes for Venia are in adobe/aem-cif-guides-venia#118How Has This Been Tested?
Added unit tests and update the mock GraphQL server used by the Venia ITs.
Screenshots (if appropriate):
Types of changes
Checklist: