-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 ee #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* introduce product v2 for 'staged' Magento field * adapt unit tests for component v2 * ensure the product and variant queries can be extended "multiple times" * add @SInCE annotation to product interface * add readme * update Magento schema to 2.4.2 EE * add mandatory "staged" field to the mock JSON responses * extend unit tests to test both product v1 and v2 components * fix POM dependencies and remove no longer needed picker implementation Co-authored-by: Levente Santha <levente@adobe.com>
* create productlist v2 component * update unit tests and GraphQL mock server for Venia ITs
# Conflicts: # bundles/core/src/test/java/com/adobe/cq/commerce/core/components/internal/models/v1/productlist/ProductListImplTest.java # bundles/core/src/test/resources/graphql/magento-graphql-search-result-with-category.json # bundles/core/src/test/resources/test-queries/graphql-requests.log # examples/bundle/src/main/resources/graphql/magento-graphql-category.json
* introduce product v2 for 'staged' Magento field * adapt unit tests for component v2 * ensure the product and variant queries can be extended "multiple times" * add @SInCE annotation to product interface * add readme * update Magento schema to 2.4.2 EE * add mandatory "staged" field to the mock JSON responses * extend unit tests to test both product v1 and v2 components * fix POM dependencies and remove no longer needed picker implementation Co-authored-by: Levente Santha <levente@adobe.com>
* create productlist v2 component * update unit tests and GraphQL mock server for Venia ITs
…nto 2.0.0-ee # Conflicts: # bundles/core/src/main/java/com/adobe/cq/commerce/core/components/models/productlist/ProductList.java # bundles/core/src/test/java/com/adobe/cq/commerce/core/components/internal/models/v1/productlist/ProductListImplTest.java # bundles/core/src/test/resources/graphql/magento-graphql-search-category-result-products.json # bundles/core/src/test/resources/test-queries/graphql-requests.log # examples/bundle/src/main/resources/graphql/magento-graphql-category.json
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
============================================
+ Coverage 87.90% 87.97% +0.06%
- Complexity 1372 1396 +24
============================================
Files 250 254 +4
Lines 6435 6472 +37
Branches 964 969 +5
============================================
+ Hits 5657 5694 +37
Misses 583 583
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dplaton
approved these changes
Jun 4, 2021
herzog31
approved these changes
Jun 10, 2021
buuhuu
approved these changes
Jun 21, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge 2.0.0 ee branch, with staged product changes we already have, finally into master.
Related Issue
CIF-1964, CIF1965 and more to come
Motivation and Context
Prepare for CIF 2.0.0
How Has This Been Tested?
Unit test & ITs added
Types of changes
Checklist: