Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-1995 - Update CIF integration tests to Magento 2.4.2 EE #515

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

cjelger
Copy link
Contributor

@cjelger cjelger commented Mar 12, 2021

  • update Magento schema to 2.4.2 EE
  • add mandatory "staged" field to the mock JSON responses
  • extend unit tests to test both product v1 and v2 components
  • fix POM dependencies and remove no longer needed picker implementation

Motivation

We need this when we change the Venia product component to v2, because we use the mock GraphQL server from the components library to test Venia. So we will have to support the staged field.

How Has This Been Tested?

Extended unit tests for both product v1 and v2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

- update Magento schema to 2.4.2 EE
- add mandatory "staged" field to the mock JSON responses
- extend unit tests to test both product v1 and v2 components
- fix POM dependencies and remove no longer needed picker implementation
@cjelger cjelger added feature New feature or request testing labels Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #515 (b1bcfa6) into CIF-1964-v2 (7d73c06) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##             CIF-1964-v2     #515      +/-   ##
=================================================
+ Coverage          87.61%   87.66%   +0.04%     
  Complexity          1240     1240              
=================================================
  Files                233      233              
  Lines               5887     5886       -1     
  Branches             861      861              
=================================================
+ Hits                5158     5160       +2     
+ Misses               574      573       -1     
+ Partials             155      153       -2     
Flag Coverage Δ Complexity Δ
integration 64.89% <100.00%> (+0.02%) 0.00 <1.00> (ø)
jest 83.33% <ø> (ø) 0.00 <ø> (ø)
karma 94.54% <ø> (ø) 0.00 <ø> (ø)
unittests 88.04% <100.00%> (+0.05%) 0.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ommerce/core/examples/servlets/GraphqlServlet.java 92.30% <100.00%> (+1.22%) 41.00 <1.00> (ø)
...e/search/internal/models/SearchResultsSetImpl.java 87.17% <0.00%> (+2.56%) 27.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d73c06...b1bcfa6. Read the comment docs.

@cjelger
Copy link
Contributor Author

cjelger commented Mar 15, 2021

Will be "verified" with #510 and the corresponding Venia PR

@cjelger cjelger merged commit 5c398b4 into CIF-1964-v2 Mar 15, 2021
@cjelger cjelger deleted the CIF-1995 branch March 15, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants