Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively build boards based on changed files #5312

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 7, 2021

This uses a step output from the test job to set the build matrix
for the board build jobs. The built boards depends on which files
were changed.

  • Changes contained within ports/*/boards/ will build each board.
  • Changes contained within ports/* will build all boards from the
    port.
  • All other file changes will build all boards.

All boards will be build for pushes in adafruit/circuitpython as
well.

A side-effect is that we no longer need to explicitly list the
boards to build. It will automatically update as new folders are
added.

Related to #4009

This uses a step output from the test job to set the build matrix
for the board build jobs. The built boards depends on which files
were changed.

* Changes contained within ports/*/boards/ will build each board.
* Changes contained within ports/* will build all boards from the
  port.
* All other file changes will build all boards.

All boards will be build for pushes in `adafruit/circuitpython` as
well.

A side-effect is that we no longer need to explicitly list the
boards to build. It will automatically update as new folders are
added.

Related to micropython#4009
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the build worked. Now we should see the artifacts uploading on the merge.

@dhalbert
Copy link
Collaborator

@tannewt See this run, which "failed" when it was not really a failure. Not sure why previous jobs like this worked.

https://github.com/adafruit/circuitpython/actions/runs/1219852307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants