Add Espressif ESP32-S2-DevKitC-1-N8R2 variant

[kylefmohr]

This is a relatively new board, purchased from here, apparently first released August 10th 2022. The official pinout is available here. It is very similar to the N4R2 version that is available for CircuitPython.

I got the majority of my code from #5998, so thanks to anecdata for that!

I would appreciate if somebody could review my changes to ci_check_duplicate_usb_vid_pid.py, as this is my first PR for this project, and I'm a little unclear on how that file works. With a micro USB cable plugged into the "UART" port of the board, this is what shows up in Device Manager in Windows

I think I added the PID/VID correctly, just want another set of eyes on them. Thanks!

[Neradoc]

What you are showing is the VID/PID of the CP2104 chip on the UART port. The VID and PID set in Circuitpython is for the native USB port of the board, and must be unique (mostly...) and properly allocated by a VID owner.
In this case, it seems that you should use the common espressif_esp32s2_devkitc_1 PID allocated by Espressif, and therefore add it to the existing list for that VID/PID in the duplicate check.
I made the changes in the suggestions.
I didn't look at the other files.

[dhalbert]

@kylefmohr Thanks for this!

I pushed a minor change to fix the formatting of tools/ci_check_duplicate_usb_vid_pid.py.

It's a good idea to create a separate branch for a PR instead of using your main, because now your main has diverged from upstream. You may want to force it back to adafruit/main later.

[kylefmohr]

@kylefmohr Thanks for this!

I pushed a minor change to fix the formatting of tools/ci_check_duplicate_usb_vid_pid.py.

It's a good idea to create a separate branch for a PR instead of using your main, because now your main has diverged from upstream. You may want to force it back to adafruit/main later.

Thank you! That makes sense. In the past I've deleted and re-forked the repo, but creating a new branch for the PR seems easier. I appreciate the assistance.

[dhalbert]

We have a Learn Guide explaining about branches: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/always-work-on-a-branch (the whole guide is worth reading if you have not seen it yet).

[kylefmohr]

We have a Learn Guide explaining about branches: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/always-work-on-a-branch (the whole guide is worth reading if you have not seen it yet).

I have not, I'll definitely give that a read! Another newbie question that I don't see covered in the guide: How did you manage to only build the firmware for the new board, and skip all other boards/ports? That seems very useful, in the past I've just waited for the build to complete entirely.

[dhalbert]

Our scripting for the automated builds checks to see where the changed files are, and if they are only in a particular port or board, it will rebuild only those ports or boards. This was done in PR #5312.

[dhalbert]

@Neradoc Does this look good to you?

[Neradoc]

There's a define for AUTORESET_DELAY_MS in mpconfigboard.h that is unnecessary. The rest looks good to go.
(To quote #6182: it never did anything but was introduced somehow)

[dhalbert]

I will fix that, and will also shorten board.c, due to the new MP_WEAK default versions of those routines.

[Neradoc]

Ah we are crossing streams !