nrf: Shrink "<peripheral> does not exist" error messages. #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code size reductions: nrf51: -132 nrf52: -188
|
I think for ports that are tight on flash this is a good optimisation. You can even go a bit further and use "doesn't" instead of "does not". For cases where there is enough flash (eg nrf52840) it might be nice to have more informative messages, which can be controlled via |
|
Merged in 4e1c2fc with "does not" replaced with "doesn't". |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Sep 7, 2021
This uses a step output from the test job to set the build matrix for the board build jobs. The built boards depends on which files were changed. * Changes contained within ports/*/boards/ will build each board. * Changes contained within ports/* will build all boards from the port. * All other file changes will build all boards. All boards will be build for pushes in `adafruit/circuitpython` as well. A side-effect is that we no longer need to explicitly list the boards to build. It will automatically update as new folders are added. Related to micropython#4009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code size reductions:
nrf51: -132
nrf52: -188