Interaction - Add crew status check for some vehicle interactions #9637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a one or more passenger in a vehicle are conscious, not captive and hostile to the interacting unit, the interactions (passenger, cargo) will not appear.
|
Haven't tested yet. How does this work with empty vehicles? |
LinkIsGrim
reviewed
Nov 10, 2023
addons/interaction/functions/fnc_canInteractWithVehicleCrew.sqf
Outdated
Show resolved
Hide resolved
It works as expected. |
LinkIsGrim
reviewed
Nov 11, 2023
|
|
||
| ((crew _vehicle) select {_x != _player && {!unitIsUAV _x}}) findIf { // ignore player and UAV units | ||
| // Units must all be unconscious, captive or friendly (side group is used in case unit is captive/unconscious) for actions to show up | ||
| !captive _x && {lifeState _x in ["HEALTHY", "INJURED"]} && {[_sidePlayer, side group _x] call BIS_fnc_sideIsEnemy} |
There was a problem hiding this comment.
Not exactly related but we should update common FUNC(isAwake) to do this lifeState check instead, methinks. These are getting bad for readability
There was a problem hiding this comment.
Generally speaking, I think we should change _unit getVariable ["ACE_isUnconscious", false] to lifeState (or EFUNC(common,isAwake), if we update it as per your suggestion) wherever possible.
LinkIsGrim
reviewed
Nov 11, 2023
LinkIsGrim
approved these changes
Nov 11, 2023
LinkIsGrim
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
FUNC(addPassengerActions). UsingobjectParentinstead ofvehicle.I opted not to go with adding a condition for interacting via
EFUNC(common,addCanInteractWithCondition), as I don't want to impose this for all vehicle interactions.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.