Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Allow pulling bodies out of wrecks #9618

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Nov 3, 2023

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Dystopian
Copy link
Contributor

If vehicle is burned then body is burned too, isn't it? That was initial point of alive check.

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Nov 4, 2023

If vehicle is burned then body is burned too, isn't it? That was initial point of alive check.

Not necessarily? Players can be unconscious and alive inside wrecks. Happens a lot with helicopter crashes.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Nov 4, 2023
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is a subjective change, though.

@Dystopian
Copy link
Contributor

Players can be unconscious and alive inside wrecks

I think if mission allows alive players inside wreck, it should eject them when vehicle becomes destroyed. Or in-mission way to pull out (e.g. useraction). But not ACE pull-out.

@johnb432
Copy link
Contributor Author

johnb432 commented Nov 4, 2023

If vehicle is burned then body is burned too, isn't it? That was initial point of alive check.
Not necessarily? Players can be unconscious and alive inside wrecks. Happens a lot with helicopter crashes.

That's was the intention - to make it possible to remove players from (burning) wrecks. Otherwise they could slowly bleed out, which isn't a particularly fun experience.

I think if mission allows alive players inside wreck, it should eject them when vehicle becomes destroyed. Or in-mission way to pull out (e.g. useraction). But not ACE pull-out.

I'm not a fan of vanilla useractions, so imo that is out of the question. As for the automatic ejecting, it doesn't feel very realistic, although to be honest pulling an unconscious person out of a raging fire/cook-off isn't too realistic either... but in terms of game play it's a decent solution.

I think more opinions are needed.

@rautamiekka
Copy link
Contributor

rautamiekka commented Nov 4, 2023

If vehicle is burned then body is burned too, isn't it? That was initial point of alive check.
Not necessarily? Players can be unconscious and alive inside wrecks. Happens a lot with helicopter crashes.

That's was the intention - to make it possible to remove players from (burning) wrecks. Otherwise they could slowly bleed out, which isn't a particularly fun experience.

Anyone who's played will say it feels unfair that there's absolutely nothing you can do if someone doesn't wake up after the wreck catches on fire, which adds undue stress on the Players and Zeuses/mission devs alike to do things absolutely precisely.

I'm not a fan of vanilla useractions, so imo that is out of the question.

Eh, better than the above.

[...] although to be honest pulling an unconscious person out of a raging fire/cook-off isn't too realistic either... but in terms of game play it's a decent solution.

Completely realistic and being done wherever possible, just very dangerous in the latter case. Raging fire is very hot but not hot enough to melt or otherwise kill by being close for a few minutes (the clothes we wear help in that), they ain't the Sun after all.

@johnb432
Copy link
Contributor Author

johnb432 commented Nov 6, 2023

@jonpas @BaerMitUmlaut @PabstMirror What do you guys think?

@BaerMitUmlaut
Copy link
Member

Does this allow pulling unconscious enemy units out of a tank?

@johnb432
Copy link
Contributor Author

johnb432 commented Nov 6, 2023

Does this allow pulling unconscious enemy units out of a tank?

Sort of, but not really.

Directly it does not, but it's possible to pull unconscious enemies out of vehicles generally speaking - should be addressed in another PR (https://github.com/acemod/ACE3/blob/master/addons/medical_gui/CfgVehicles.hpp#L60 seems to be the cause of the issue).

This PR gives the ability to pull out unconscious enemies from wrecks.

@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Nov 10, 2023
@LinkIsGrim LinkIsGrim merged commit c850a6a into acemod:master Nov 10, 2023
5 checks passed
@johnb432 johnb432 deleted the pull-out-bodies branch January 14, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOGPF - Cannot pull players from burning helicopter wrecks.
6 participants