-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): fix hangs in lightwalletd tests by checking concurrent process output in different threads #4828
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4828 +/- ##
==========================================
+ Coverage 78.80% 78.88% +0.07%
==========================================
Files 305 305
Lines 38733 38730 -3
==========================================
+ Hits 30524 30551 +27
+ Misses 8209 8179 -30 |
I ran 77 of these tests locally overnight, and they all succeeded. I just need to fix a bug in the GitHub actions where we're using an old cached state. |
032c6a4
to
9fdf5f5
Compare
82b0fd4
to
3ae946b
Compare
This should all work now, we're just waiting for CI. |
c2e6eb9
to
c2dc411
Compare
…ng for lightwalletd
c2dc411
to
1d9ec5a
Compare
I needed to re-do the fix, because the problem was actually deadlocks from not reading the |
There was a google cloud SSH failure:
https://github.com/ZcashFoundation/zebra/runs/7553151823?check_suite_focus=true#step:6:332 I've never seen one of these before, so I restarted those jobs. |
Admin-merging because the one failing test is going to be fixed soon. There's just one issue with a regex in the send transactions test, I'll fix it in PR #4840. |
Motivation
lightwalletd is unstable in our CI, because
zebrad
hangs when its log buffer fills up.Close #4820
Depends-On: #4826
Solution
zebrad
andlightwalletd
logs in different threads, to avoid deadlocks due to the log buffer filling upThis increases the sync test time, but we can fix that in later PRs.
Related fixes:
main
branch, then any branchReview
This is a high-priority sync fix.
Reviewer Checklist
Follow Up Tasks