Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lightwalletd test hangs by checking process output in dedicated threads #4820

Closed
teor2345 opened this issue Jul 25, 2022 · 0 comments · Fixed by #4828
Closed

Fix lightwalletd test hangs by checking process output in dedicated threads #4820

teor2345 opened this issue Jul 25, 2022 · 0 comments · Fixed by #4828
Assignees
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 25, 2022

Motivation

Sometimes lightwalletd hangs, but we make the Zebra integration test pass anyway.

When this happens, we update the lightwalletd cached state with a small number of blocks, so future tests are slow, or they fail because they don't have enough blocks.

Alternative Fixes

Fix lightwalletd hangs by giving each child process a dedicated test thread to check logs.

OR

When lightwalletd hangs, restart it.

OR

When lightwalletd hangs, don't update the cached lightwalletd state

OR

In the Rust test harnesses:

  • don't check that the lightwalletd cached state contains a minimum number of blocks
  • increase the test timeouts to allow a full lightwalletd sync
@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles S-needs-triage Status: A bug report needs triage P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd A-rust Area: Updates to Rust code labels Jul 25, 2022
@teor2345 teor2345 self-assigned this Jul 26, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Jul 26, 2022
@teor2345 teor2345 changed the title When lightwalletd hangs, make the test pass, and ignore any problems with the cached state Fix lightwalletd test hangs by checking process output in dedicated threads Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
2 participants