-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2. fix(state): Make FindHeaders and FindHashes run concurrently with state updates #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #4826 +/- ##
==========================================
- Coverage 78.88% 78.78% -0.10%
==========================================
Files 305 305
Lines 38559 38733 +174
==========================================
+ Hits 30418 30517 +99
- Misses 8141 8216 +75 |
2 tasks
oxarbitrage
previously approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
And speed up the contains_block_hash state query.
032c6a4
to
9fdf5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-state
Area: State / database changes
C-bug
Category: This is a bug
I-integration-fail
Continuous integration fails, including build and test failures
I-slow
Problems with performance or responsiveness
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra reads 160 headers for each FindHeaders request.
The FindHeaders requests used to take 5-10 seconds to answer, they might still be a bit slow.
So we want to run them concurrently with state updates.
Depends-On: #4825
Solution
Review
This is an urgent PR to fix Zebra sync performance.
Reviewer Checklist