Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Ignore lightwalletd hangs for now #4663

Merged
merged 4 commits into from
Jun 27, 2022
Merged

fix(ci): Ignore lightwalletd hangs for now #4663

merged 4 commits into from
Jun 27, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 21, 2022

Motivation

Sometimes lightwalletd hangs when it gets near the tip.

We can't really fix that, so we just check that it has synced some blocks instead.

Depends-On: #4669, #4675

Solution

  • Allow "adding block to cache" as an alternative tip log, where we previously required "waiting for block"

Review

This is pretty urgent, it's blocking some lightwalletd tests.

Reviewer Checklist

  • CI passes

Follow Up Tasks

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd labels Jun 21, 2022
@teor2345 teor2345 requested a review from a team as a code owner June 21, 2022 05:59
@teor2345 teor2345 removed the request for review from a team June 21, 2022 05:59
@teor2345 teor2345 self-assigned this Jun 21, 2022
@teor2345 teor2345 requested a review from upbqdn June 21, 2022 05:59
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #4663 (09ba398) into main (e709420) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4663      +/-   ##
==========================================
+ Coverage   78.83%   78.97%   +0.13%     
==========================================
  Files         304      304              
  Lines       37506    37506              
==========================================
+ Hits        29568    29619      +51     
+ Misses       7938     7887      -51     

@gustavovalverde
Copy link
Member

Was reviewing to approve, but test is still failing even though it shows a matching regex

{"app":"lightwalletd","level":"info","msg":"Adding block to cache 1020427 000000000049429cfbc02c7d798e23e5db748310eda499977569a5484116ab46","time":"2022-06-21T07:25:34Z"}

But the actual regex is expecting a different output:

Match Regex:
   [
       "finished initial sync to chain tip, using gossiped blocks .*sync_percent.*=.*100\\.",
   ]

FMT is also complaining

Maybe @conradoplg can have a look at this one.

@conradoplg
Copy link
Collaborator

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

update

✅ Branch has been successfully updated

@conradoplg
Copy link
Collaborator

Maybe @conradoplg can have a look at this one.

That's the Zebra sync failure which was hopefully solved by #4662 . I've updated this PR to pick up the fix.

@teor2345
Copy link
Contributor Author

The sync failure in this PR should get better after #4669, and whatever fixes we need to fix the sync speed.

@gustavovalverde
Copy link
Member

I'm re-testing #4669. Let's wait for the result, merge it to main and then update this PR to confirm all checks pass

@teor2345
Copy link
Contributor Author

This is blocking a bunch of work, so I made it "Critical" priority.

@teor2345 teor2345 requested a review from a team as a code owner June 22, 2022 21:35
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team June 22, 2022 21:35
@teor2345
Copy link
Contributor Author

I'm re-testing #4669. Let's wait for the result, merge it to main and then update this PR to confirm all checks pass

#4669 passed, I manually rebased on that branch and the latest main.

So the diff will contain PR #4669 as well, but the CI results will be correct.

@teor2345
Copy link
Contributor Author

teor2345 commented Jun 23, 2022

This is still failing, it might need:

@teor2345 teor2345 added A-rust Area: Updates to Rust code and removed A-devops Area: Pipelines, CI/CD and Dockerfiles labels Jun 23, 2022
@teor2345 teor2345 removed the request for review from gustavovalverde June 23, 2022 22:47
@upbqdn
Copy link
Member

upbqdn commented Jun 27, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

update

✅ Branch has been successfully updated

@mergify mergify bot merged commit d37d8aa into main Jun 27, 2022
@mergify mergify bot deleted the fix-lwd-ci branch June 27, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants