-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Ignore lightwalletd hangs for now #4663
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4663 +/- ##
==========================================
+ Coverage 78.83% 78.97% +0.13%
==========================================
Files 304 304
Lines 37506 37506
==========================================
+ Hits 29568 29619 +51
+ Misses 7938 7887 -51 |
Was reviewing to approve, but test is still failing even though it shows a matching regex
But the actual regex is expecting a different output:
FMT is also complaining Maybe @conradoplg can have a look at this one. |
@Mergifyio update |
✅ Branch has been successfully updated |
That's the Zebra sync failure which was hopefully solved by #4662 . I've updated this PR to pick up the fix. |
The sync failure in this PR should get better after #4669, and whatever fixes we need to fix the sync speed. |
I'm re-testing #4669. Let's wait for the result, merge it to |
This is blocking a bunch of work, so I made it "Critical" priority. |
This is still failing, it might need:
|
@Mergifyio update |
✅ Branch has been successfully updated |
Motivation
Sometimes
lightwalletd
hangs when it gets near the tip.We can't really fix that, so we just check that it has synced some blocks instead.
Depends-On: #4669, #4675
Solution
Review
This is pretty urgent, it's blocking some lightwalletd tests.
Reviewer Checklist
Follow Up Tasks
GetMempoolTx
andGetMempoolStream
test #4537