-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Split instance and volume creation out of the test job #4675
Conversation
a91eb74
to
6ab1333
Compare
I'm running checkpoint and full syncs here: We want the setup and test jobs for checkpoint and tip to run successfully. |
Sync timed out at 80%, I guess it needs #4679 ? |
I checked the cached state disk and regular tests, and they seem to be running the right jobs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
A full sync takes about 6 hours, which is also the GitHub actions time limit.
This is part of ticket #4661, but it only splits off test setup.
We might need this to unblock:
GetMempoolTx
andGetMempoolStream
test #4537Designs
Split the existing sync jobs into 2 jobs:
Solution
Split GCP test jobs into:
Related documentation:
Review
These fixes are blocking 3 other PRs, so it's urgent.
Reviewer Checklist