Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Split instance and volume creation out of the test job #4675

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 22, 2022

Motivation

A full sync takes about 6 hours, which is also the GitHub actions time limit.

This is part of ticket #4661, but it only splits off test setup.

We might need this to unblock:

Designs

Split the existing sync jobs into 2 jobs:

  • create instance & volumes
  • run test

Solution

Split GCP test jobs into:

  • Create instance & create docker volume
  • Run test

Related documentation:

  • Sort workflow variables into categories and add descriptions
  • Document each workflow job and step

Review

These fixes are blocking 3 other PRs, so it's urgent.

Reviewer Checklist

  • CI passes
  • New setup job runs in checkpoint sync, full sync, and normal tests

@teor2345 teor2345 self-assigned this Jun 22, 2022
@teor2345 teor2345 marked this pull request as ready for review June 23, 2022 06:18
@teor2345 teor2345 requested a review from a team as a code owner June 23, 2022 06:18
@teor2345 teor2345 requested review from dconnolly and removed request for a team June 23, 2022 06:18
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement P-High 🔥 I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd labels Jun 23, 2022
@teor2345
Copy link
Contributor Author

I'm running checkpoint and full syncs here:
https://github.com/ZcashFoundation/zebra/actions/runs/2547182613

We want the setup and test jobs for checkpoint and tip to run successfully.
(It looks like all of the right jobs are in the workflow.)

@teor2345 teor2345 changed the title fix(ci): Split full sync into launch, checkpoint logs and full validation logs fix(ci): Split instance and volume creation out of the test job Jun 23, 2022
@conradoplg
Copy link
Collaborator

Sync timed out at 80%, I guess it needs #4679 ?

@teor2345
Copy link
Contributor Author

Sync timed out at 80%, I guess it needs #4679 ?

This isn't the complete implementation of #4661, so it's ok for it to timeout for now

@teor2345
Copy link
Contributor Author

I checked the cached state disk and regular tests, and they seem to be running the right jobs:

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mergify bot added a commit that referenced this pull request Jun 23, 2022
@mergify mergify bot merged commit b35ab67 into main Jun 23, 2022
@mergify mergify bot deleted the split-full-sync branch June 23, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants