Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Ignore lightwalletd hangs for now #4663

Merged
merged 4 commits into from
Jun 27, 2022
Merged

fix(ci): Ignore lightwalletd hangs for now #4663

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca6cf72
Ignore lightwalletd hangs for now
teor2345 Jun 21, 2022
3011b79
cargo fmt --all
teor2345 Jun 21, 2022
3beae7e
cargo +stable fmt --all
teor2345 Jun 22, 2022
09ba398
Merge branch 'main' into fix-lwd-ci
mergify[bot] Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions zebrad/tests/acceptance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,8 @@ fn lightwalletd_integration_test(test_type: LightwalletdTestType) -> Result<()>
// lightwalletd will keep retrying getblock.
if !test_type.allow_lightwalletd_cached_state() {
if test_type.needs_zebra_cached_state() {
lightwalletd.expect_stdout_line_matches("[Aa]dding block to cache")?;
lightwalletd
.expect_stdout_line_matches("([Aa]dding block to cache)|([Ww]aiting for block)")?;
} else {
lightwalletd.expect_stdout_line_matches(regex::escape(
"Waiting for zcashd height to reach Sapling activation height (419200)",
Expand All @@ -1340,7 +1341,14 @@ fn lightwalletd_integration_test(test_type: LightwalletdTestType) -> Result<()>
// Wait for Zebra to sync its cached state to the chain tip
zebrad.expect_stdout_line_matches(SYNC_FINISHED_REGEX)?;

// Wait for lightwalletd to sync some blocks
lightwalletd
.expect_stdout_line_matches("([Aa]dding block to cache)|([Ww]aiting for block)")?;

// Wait for lightwalletd to sync to Zebra's tip
//
// TODO: re-enable this code when lightwalletd hangs are fixed
#[cfg(lightwalletd_hang_fix)]
lightwalletd.expect_stdout_line_matches("[Ww]aiting for block")?;

// Check Zebra is still at the tip (also clears and prints Zebra's logs)
Expand All @@ -1350,7 +1358,9 @@ fn lightwalletd_integration_test(test_type: LightwalletdTestType) -> Result<()>
// But when it gets near the tip, it starts using the mempool.
//
// adityapk00/lightwalletd logs mempool changes, but zcash/lightwalletd doesn't.
#[cfg(adityapk00_lightwalletd)]
//
// TODO: re-enable this code when lightwalletd hangs are fixed
#[cfg(lightwalletd_hang_fix)]
{
lightwalletd.expect_stdout_line_matches(regex::escape(
"Block hash changed, clearing mempool clients",
Expand Down