Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4. doc(state): explain how Zebra stays below Windows open file limits #3590

Merged
merged 1 commit into from
Feb 24, 2022
Merged

4. doc(state): explain how Zebra stays below Windows open file limits #3590

merged 1 commit into from
Feb 24, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 20, 2022 •
edited
Loading

Motivation

This PR contains revisions after the review on PR #3539, because that code has been moved by other PRs.

Solution

  • explain how Zebra stays below Windows open file limits

Review

@jvff reviewed PR #3539.

This PR is based on PR #3579, it can be moved out of draft once that PR merges.

Reviewer Checklist

  • Documentation makes sense

@teor2345 teor2345 changed the base branch from main to zebra-db-high-level-api February 20, 2022 21:12
@teor2345 teor2345 requested a review from jvff February 20, 2022 21:13
@teor2345 teor2345 added A-docs Area: Documentation C-bug Category: This is a bug A-state Area: State / database changes C-cleanup Category: This is a cleanup P-Medium ⚡ and removed C-bug Category: This is a bug labels Feb 20, 2022
@teor2345 teor2345 mentioned this pull request Feb 20, 2022
Merged
2 tasks
@codecov
Copy link

codecov bot commented Feb 20, 2022 •
edited
Loading

Codecov Report

Merging #3590 (37e2376) into main (22b8a60) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
- Coverage   79.96%   79.83%   -0.13%     
==========================================
  Files         281      281              
  Lines       32582    32584       +2     
==========================================
- Hits        26053    26013      -40     
- Misses       6529     6571      +42

@teor2345 teor2345 force-pushed the zebra-db-high-level-api branch from c755bd1 to 8a277ae Compare February 21, 2022 03:01
@teor2345 teor2345 force-pushed the rlimit-0.7.0-cleanup branch from 59978e1 to f8e0886 Compare February 21, 2022 03:02
@teor2345 teor2345 marked this pull request as draft February 21, 2022 23:01
@teor2345 teor2345 force-pushed the zebra-db-high-level-api branch from 8a277ae to d584e61 Compare February 22, 2022 07:04
@teor2345 teor2345 force-pushed the rlimit-0.7.0-cleanup branch from f8e0886 to 482a23e Compare February 22, 2022 07:04
@teor2345 teor2345 requested a review from jvff February 22, 2022 07:05
@teor2345
Copy link
Contributor Author

I rebased the PR series on main.

@teor2345 teor2345 mentioned this pull request Feb 22, 2022
Merged
2 tasks
jvff
jvff previously approved these changes Feb 22, 2022
View reviewed changes
@teor2345 teor2345 force-pushed the zebra-db-high-level-api branch from d584e61 to ef8ca0b Compare February 22, 2022 22:23
@teor2345 teor2345 force-pushed the rlimit-0.7.0-cleanup branch from 482a23e to 6153560 Compare February 22, 2022 22:25
Base automatically changed from zebra-db-high-level-api to main February 23, 2022 00:43
@teor2345 teor2345 marked this pull request as ready for review February 23, 2022 00:45
@teor2345
Copy link
Contributor Author

@jvff mergify dismissed your review, would you mind re-reviewing?

@teor2345 teor2345 force-pushed the rlimit-0.7.0-cleanup branch from 6153560 to 37e2376 Compare February 23, 2022 01:03
conradoplg
conradoplg approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get things going since it was already approved, mergify just updated it, and it's documentation only

mergify bot added a commit that referenced this pull request Feb 23, 2022
@mergify
Merge of #3590
adb4249
@mergify mergify bot mentioned this pull request Feb 23, 2022
Closed
45 tasks
@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Feb 24, 2022
@mergify
Merge of #3590
3fbd862
@mergify mergify bot mentioned this pull request Feb 24, 2022
Closed
45 tasks
@mergify mergify bot merged commit 397ba1f into main Feb 24, 2022
@mergify mergify bot deleted the rlimit-0.7.0-cleanup branch February 24, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

@jvff jvff jvff left review comments

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation A-state Area: State / database changes C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @conradoplg @jvff