3. refactor(state): move database reads and writes to a new zebra_db module

[teor2345]

Motivation

As part of changing the database, we'll need to make sure all database accesses go through a well-defined API.

As the third step, we need to make sure all database reads and writes go through the same module.
(This makes sure all access to the database respects any consistency rules.)

Solution

Code Movement:

• split up commit_finalized_direct into validation and writes
• move database reads and writes to a new zebra_db module
• add the newly created zebra_db module to the cached state CI job filter

Related Cleanups:

• make finalized value pool method names consistent

Resolves #2588
(#2588 was needed for #3151 anyway.)

Part of ticket #3151.

Based on PR #3578, feel free to move this PR out of draft after it merges.

Review

@oxarbitrage can review this PR.

git diff --color-moved could make the review a lot easier.

Reviewer Checklist

• Code moves are correct
• Existing tests pass

Follow Up Work

• split up the writes into their own methods, so it's easy to see the changes to each specific type's serialization

[codecov]

Codecov Report

Merging #3579 (ef8ca0b) into main (fc7ecfe) will decrease coverage by 0.00%.
The diff coverage is 93.11%.

@@            Coverage Diff             @@
##             main    #3579      +/-   ##
==========================================
- Coverage   79.88%   79.87%   -0.01%     
==========================================
  Files         280      281       +1     
  Lines       32554    32582      +28     
==========================================
+ Hits        26005    26025      +20     
- Misses       6549     6557       +8     

[oxarbitrage]

I think this looks good, i will approve after #3578 gets merged.

[teor2345]

I rebased the PR series on main.

[teor2345]

@oxarbitrage I rebased this PR on main to resolve conflicts. It should be ready to merge now.