1. fix(state): use the new increase_nofile_limit function from rlimit 0.7.0
#3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
commented
Feb 15, 2022
teor2345
commented
Feb 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #3539 +/- ##
==========================================
+ Coverage 78.34% 80.18% +1.84%
==========================================
Files 267 276 +9
Lines 31526 32373 +847
==========================================
+ Hits 24698 25958 +1260
+ Misses 6828 6415 -413 |
…0.7.0 Also: - upgrades to rlimit 0.7.0 - updates types to match the breaking changes in rlimit - deletes a manual implementation that was similar to `increase_nofile_limit`, but not as good on macOS and some BSDs
82cd6af to
c047205
Compare
increase_nofile_limit function from rlimit 0.7.0increase_nofile_limit function from rlimit 0.7.0
2 tasks
jvff
approved these changes
Feb 18, 2022
1 task
|
@Mergifyio update |
✅ Branch has been successfully updated |
This comment was marked as resolved.
This comment was marked as resolved.
45 tasks
1 task
It seems to work now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
rlimit0.7.0 is a breaking change. It implements a newincrease_nofile_limitfunction, which replaces a lot of code we'd written.Makes code changes required by this dependency update:
Part of:
API reference
https://docs.rs/rlimit/latest/rlimit/fn.increase_nofile_limit.html
Solution
increase_nofile_limit, but not as good on macOS and some BSDsReview
@jvff can review this dependency upgrade PR.
Reviewer Checklist