Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest compatible versions of all dependencies #3115

Closed
teor2345 opened this issue Nov 29, 2021 · 7 comments · Fixed by #3625
Closed

Update to the latest compatible versions of all dependencies #3115

teor2345 opened this issue Nov 29, 2021 · 7 comments · Fixed by #3625
Assignees
Labels
A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement C-security Category: Security issues

Comments

@teor2345
Copy link
Contributor

teor2345 commented Nov 29, 2021

Motivation

Zebra isn't using the latest versions of its dependencies, because we skipped some dependency updates during the NU5 sprints.

We should update dependencies, to get as many bug and security fixes as possible.

Note: we've been discussing in Discord how to split this ticket into smaller parts

Tasks

  • Run cargo update to update to the latest versions of each dependency
  • Revert any incompatible version updates (but try to find the latest compatible version)
  • Revert any dependency changes that cause a lot of duplicates (particularly with tower, tracing, and orchard)
  • Update the duplicate dependency checks in deny.toml
@teor2345 teor2345 added A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Medium C-security Category: Security issues labels Nov 29, 2021
@mpguerra
Copy link
Contributor

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 15, 2021
@teor2345 teor2345 added P-Low and removed P-Medium labels Jan 6, 2022
@teor2345
Copy link
Contributor Author

This ticket might have some helpful commands in it.
But we want the maximum versions in both Cargo.toml and Cargo.lock.

https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/228

@upbqdn
Copy link
Member

upbqdn commented Feb 22, 2022

I ran cargo update and built Zebra, and all tests are passing. I just realized it's not clear to me what needs to be done in this issue.

@teor2345
Copy link
Contributor Author

teor2345 commented Feb 23, 2022

I ran cargo update and built Zebra, and all tests are passing. I just realized it's not clear to me what needs to be done in this issue.

Did cargo update change the Cargo.lock or Cargo.toml files?
Maybe we need to use cargo upgrade?

I'm just talking with @conradoplg about this ticket, we think it might be a lot more complicated than we expected.

So we might close this ticket, and just do these upgrades using dependabot.

@upbqdn
Copy link
Member

upbqdn commented Feb 23, 2022

Running cargo update changed only the Cargo.lock file.

@upbqdn
Copy link
Member

upbqdn commented Feb 23, 2022

cargo upgrade changes toml files, and causes conflicts of dependencies. I'm trying to resolve them.

@teor2345
Copy link
Contributor Author

teor2345 commented Feb 23, 2022

Yeah, that's what I thought might happen. It's ok to skip any updates that cause conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement C-security Category: Security issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants