Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Unity 2020 LTS support and native platform implementation #130

Merged
merged 80 commits into from
Sep 4, 2021

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Apr 20, 2021

XRTK - Mixed Reality Toolkit Pull Request

Overview

Support for Unity Editor 2020+ as well as native platform implementations for existing services and data proviers.

Changes

Breaking Changes

  • Breaks all old WMR platform services and providers. Upgrade and migration guide TBA

Related Changes

Known Issues

  • Hand tracking works, but isn't synced with the local player space. Seems to drift as you walk and turn around the space.
  • Spatial Meshing doesn't seem to show up/get generated.

# Conflicts:
#	XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Profiles~/WindowsMixedRealityPlatformConfigurationsProfile.asset
# Conflicts:
#	XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/package.json
@StephenHodgson
Copy link
Contributor Author

@FejZa What all is needed to finish up this PR?

@StephenHodgson StephenHodgson marked this pull request as ready for review July 9, 2021 18:20
@StephenHodgson StephenHodgson added Ready for review PR finished primary development, open for review and removed In Progress PR currently still being developed labels Jul 9, 2021
@StephenHodgson
Copy link
Contributor Author

image
@FejZa

@FejZa
Copy link
Contributor

FejZa commented Jul 10, 2021

@StephenHodgson sorry for the delay. This needs restoring support for WMR gestures using native APIs and testing the spatial mapping.

@FejZa
Copy link
Contributor

FejZa commented Jul 10, 2021

I'll look into that error.

@StephenHodgson StephenHodgson marked this pull request as draft July 12, 2021 01:43
@StephenHodgson StephenHodgson changed the title Unity 2020 editor support and native platform implementation Unity 2020 LTS support and native platform implementation Jul 12, 2021
@StephenHodgson
Copy link
Contributor Author

Just gonna sync the discussion and feedback from Discord here:

  • Hand tracking works, but isn't synced with the local player space. Seems to drift as you walk and turn around the space.
  • Spatial Meshing doesn't seem to show up/get generated.

@StephenHodgson StephenHodgson added In Progress PR currently still being developed and removed Ready for review PR finished primary development, open for review labels Aug 21, 2021
@StephenHodgson StephenHodgson self-assigned this Sep 2, 2021
@StephenHodgson StephenHodgson marked this pull request as ready for review September 4, 2021 16:20
@StephenHodgson StephenHodgson merged commit e267300 into development Sep 4, 2021
@StephenHodgson StephenHodgson deleted the feature/unity-2020-x branch September 4, 2021 16:20
XRTK-Build-Bot pushed a commit that referenced this pull request Jan 17, 2022
# XRTK - Mixed Reality Toolkit Pull Request

## Overview
<!-- Please provide a clear and concise description of the pull request. -->
Support for Unity Editor 2020+ as well as native platform implementations for existing services and data proviers.

## Changes
<!-- Brief list of the targeted features that are being changed. -->

- Fixes: #83
- Fixes: #22 
- Fixes: #50 
- Fixes: #144

## Breaking Changes
<!--  Are there any breaking changes included in this change that would prevent or cause issue for existing projects? -->

- Breaks all old WMR platform services and providers. Upgrade and migration guide TBA

## Related Changes

<!--  Include any submodule related Pull Request links here -->
- XRTK/com.xrtk.core#815

## Known Issues

- [ ] Hand tracking works, but isn't synced with the local player space. Seems to drift as you walk and turn around the space.
- [ ] Spatial Meshing doesn't seem to show up/get generated.

Co-authored-by: Dino Fejzagić <dino.f@live.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change In Progress PR currently still being developed
Projects
None yet
2 participants