Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Build System doesn't properly check min sdk requirements for platforms. #144

Closed
StephenHodgson opened this issue Jun 2, 2021 · 0 comments · Fixed by #130
Closed

Build System doesn't properly check min sdk requirements for platforms. #144

StephenHodgson opened this issue Jun 2, 2021 · 0 comments · Fixed by #130
Labels
Bug Something isn't working

Comments

@StephenHodgson
Copy link
Contributor

XRTK - Mixed Reality Toolkit Bug Report

Describe the bug

Recently we updated our build machines, but they failed in unexpected ways when the windows uwp sdks were not installed. Theoretically Unity should have complained and threw an appropriate error, but didn't. We could add a check in the build pipeline to validate sdk dependencies.
@StephenHodgson StephenHodgson transferred this issue from XRTK/com.xrtk.core Jul 12, 2021
@StephenHodgson StephenHodgson mentioned this issue Jul 12, 2021
Merged
2 tasks
@StephenHodgson StephenHodgson added the Bug Something isn't working label Jul 12, 2021
StephenHodgson added a commit that referenced this issue Sep 4, 2021
@StephenHodgson @FejZa
Unity 2020 LTS support and native platform implementation (#130)
e267300 
# XRTK - Mixed Reality Toolkit Pull Request

## Overview
<!-- Please provide a clear and concise description of the pull request. -->
Support for Unity Editor 2020+ as well as native platform implementations for existing services and data proviers.

## Changes
<!-- Brief list of the targeted features that are being changed. -->

- Fixes: #83
- Fixes: #22 
- Fixes: #50 
- Fixes: #144

## Breaking Changes
<!--  Are there any breaking changes included in this change that would prevent or cause issue for existing projects? -->

- Breaks all old WMR platform services and providers. Upgrade and migration guide TBA

## Related Changes

<!--  Include any submodule related Pull Request links here -->
- XRTK/com.xrtk.core#815

## Known Issues

- [ ] Hand tracking works, but isn't synced with the local player space. Seems to drift as you walk and turn around the space.
- [ ] Spatial Meshing doesn't seem to show up/get generated.

Co-authored-by: Dino Fejzagić <dino.f@live.de>
XRTK-Build-Bot pushed a commit that referenced this issue Jan 17, 2022
@StephenHodgson @FejZa
Unity 2020 LTS support and native platform implementation (#130)
f82d417 
# XRTK - Mixed Reality Toolkit Pull Request

## Overview
<!-- Please provide a clear and concise description of the pull request. -->
Support for Unity Editor 2020+ as well as native platform implementations for existing services and data proviers.

## Changes
<!-- Brief list of the targeted features that are being changed. -->

- Fixes: #83
- Fixes: #22 
- Fixes: #50 
- Fixes: #144

## Breaking Changes
<!--  Are there any breaking changes included in this change that would prevent or cause issue for existing projects? -->

- Breaks all old WMR platform services and providers. Upgrade and migration guide TBA

## Related Changes

<!--  Include any submodule related Pull Request links here -->
- XRTK/com.xrtk.core#815

## Known Issues

- [ ] Hand tracking works, but isn't synced with the local player space. Seems to drift as you walk and turn around the space.
- [ ] Spatial Meshing doesn't seem to show up/get generated.

Co-authored-by: Dino Fejzagić <dino.f@live.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unity 2020 LTS support and native platform implementation XRTK/com.xrtk.wmr
1 participant
@StephenHodgson