CPLAT-4160 v2.0.0 (Dart 2) #240
Conversation
Clean up the rest of the Map grossness left over from DDC workarounds
[2.0.0-dev - dart2] AF-233 Consume react-dart callable class fixes
...r_react/component_declaration/builder_integration_tests/accessor_mixin_integration_test.dart
Outdated
Show resolved
Hide resolved
|
Note to reviewers: Added a second builder which uses the same factory as the Here's the commit to update the build config: 58da397 |
Now that we're committing generated files for over_react, we no longer need to use tuneup, which uses the analysis server under the hood instead of the cli. The cli currently doesn't support resolving of files under .dart_tool, the analysis server does.
51a8154 to
feebb25
Compare
| generate_for: | ||
| exclude: | ||
| # This tests un-built behavior, and therefore should not be built | ||
| - "test/over_react/component_declaration/builder_helpers_test.dart" | ||
| over_react|overReactBuilder: | ||
| enabled: false |
There was a problem hiding this comment.
So this only disables it for this package? Is that how targets.$default works?
There was a problem hiding this comment.
Yes, that only does this for this package. The $default target specifies the behavior that consumers will use when running builds on this package: https://github.com/dart-lang/build/tree/master/build_config#dividing-a-package-into-build-targets
There was a problem hiding this comment.
Consuming packages' builds are unaffected by that (only applies to over_react package)
|
@corwinsheahan-wf @evanweible-wf does this need the RM-friendly ticket number / "Release over_react 2.0.0" added to the title in order for MARV to pick it up? |
|
+1 |
| test: ^0.12.34 | ||
|
|
||
| transformers: | ||
| - over_react: |
There was a problem hiding this comment.
Goodbye old friend 👋
|
QA +1
@Workiva/release-management-p |
Description
Merging the integration branch into master. The Dart1 master branch is now
master_dart1.All of the changes here have been previously reviewed and tested in one of these PRs:
https://github.com/Workiva/over_react/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+base%3A2.0.0-dev
Testing suggestions:
Potential areas of regression:
Yeah for sure for sure.