Skip to content

Commit

Permalink
Use dartanalyzer cli instead of tuneup
Browse files Browse the repository at this point in the history
Now that we're committing generated files for over_react, we no longer
need to use tuneup, which uses the analysis server under the hood
instead of the cli. The cli currently doesn't support resolving of files
under .dart_tool, the analysis server does.
  • Loading branch information
corwinsheahan-wf committed Feb 11, 2019
1 parent 5fc1fd2 commit feebb25
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@ dart:
- stable
script:
- pub run build_runner build --delete-conflicting-outputs
# tuneup uses the analysis server under the hood for analysis instead of dartanalyzer. The server can
# resolve elements from built files under .dart_tool, the dartanalyzer cli currently does not.
- pub global activate tuneup
- pub global run tuneup check --ignore-infos
- pub run dart_dev analyze
# TODO: Remove ignore on analyzer once the wdesk ecosystem is all on a Dart 2 compat major version and we no longer need a "pinned" dep
- pub run dependency_validator --no-fatal-pins -i coverage,build_web_compilers,analyzer,build_runner,built_value_generator
# run tests on ddc output
Expand Down

0 comments on commit feebb25

Please sign in to comment.