Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Dart 2.0 🎉 #3

Merged
merged 8 commits into from
Feb 12, 2019
Merged

Update to Dart 2.0 🎉 #3

merged 8 commits into from
Feb 12, 2019

Conversation

leerob
Copy link
Owner

@leerob leerob commented Feb 10, 2019

  • Ran over_react_codemod on the codebase
  • Updated versions in the pubspec.yaml and got pub get to run successfully
  • Updated the components pulled from the over_react examples
  • Updated documentation

Hopefully you guys (@evanweible-wf @corwinsheahan-wf and crew) can use this as an example for people migrating as you roll out Dart 2 support. I've been monitoring analytics on my blog post (here) that uses this tutorial and it's still getting ~100 views per week, as well as ranking on Google when you search "Dart React", so I'm hoping to get this updated so it's accurately promoting Workiva OSS.

@evanweible-wf
Copy link
Contributor

@leerob I think this should take care of the build failure you're seeing: #4

@leerob
Copy link
Owner Author

leerob commented Feb 11, 2019

That worked! I'm able to run locally now 🎉

2019-02-11 12 19 41

I'll work on getting the documentation/blog post updated.

@leerob
Copy link
Owner Author

leerob commented Feb 11, 2019

Hmmm. Running pub run build_runner test locally does not work. ddev test also doesn't work. Is there further configuration needed for either of those? I'm surprised it works on Travis but not locally.

Should I be recommending using build_runner test for now, or ddev test? @evanweible-wf

I've got the docs mostly updated now, should be almost ready.

@corwinsheahan-wf
Copy link

corwinsheahan-wf commented Feb 12, 2019

@leerob Looks like your dev.dart file is set up correctly. I didn't have any issue running tests via ddev test. What's the error you're seeing?

@evanweible-wf
Copy link
Contributor

@leerob pub run build_runner test works for me locally on the latest commit. It's possible that that your .dart_tool/build/ directory got in a bad state from the failed build you were encountering earlier, could you try removing that directory and then running a build/tests again?

I think recommending build_runner test in this project makes the most sense. At this point ddev test isn't doing a whole lot and running build_runner test will probably become more common on Dart 2 so it'd be good to make people familiar.

@leerob
Copy link
Owner Author

leerob commented Feb 12, 2019

@evanweible-wf @corwinsheahan-wf Yep, that appeared to be the issue. Blowing away .dart_tool fixed the issue and pub run build_runner test ran successfully.

Maybe I can swing back and update this to use ddev test in the future, since the -n is helpful as projects scale.

@leerob leerob merged commit 17bdce3 into master Feb 12, 2019
@leerob leerob deleted the dart-2-update branch February 12, 2019 00:17
@leerob
Copy link
Owner Author

leerob commented Feb 12, 2019

Woohoo! 🎉 The blog post has been updated (leerob/site#6) and is live here.

I'll probably post it to /r/dartlang to try and get some eyes on OverReact 2.0 when it's released (Workiva/over_react#240).

@evanweible-wf
Copy link
Contributor

Maybe I can swing back and update this to use ddev test in the future, since the -n is helpful as projects scale.

That's actually a feature of the test package itself, ddev test just proxies the flag. You can pass whatever flags you'd like to the underlying test runner like so:

pub run build_runner test -- -n 'pattern'

And thanks, much appreciated! 2.0 should be published tonight or tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants