Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak version ranges to allow pub get in Dart 2 #171

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

maxwellpeterson-wf
Copy link
Member

Ultimate problem:

over_react specifies some maximum ranges to prevent Dart 2 resolutions.
The sdk 'environment' range should limit this for us.

How it was fixed:

Expand version ranges on analyzer, built_value, and quiver

Testing suggestions:

CI passes


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary-wf
Copy link

aviary-wf commented Aug 1, 2018

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          34       34           
  Lines        1612     1612           
=======================================
  Hits         1523     1523           
  Misses         89       89

@sebastianmalysa-wf
Copy link
Contributor

QA +1

  • Dev +1's
  • CI passes

@Workiva/release-management-pp

@sebastianmalysa-wf sebastianmalysa-wf merged commit 0a4708a into master Aug 1, 2018
@maxwellpeterson-wf maxwellpeterson-wf deleted the analyzer-version branch August 1, 2018 03:49
@aaronlademann-wf
Copy link
Contributor

I'm going to revert this since it is causing 15+ minute pub get run times using the Dart 1.x version solver.

I'll re-open a new PR to merge them into the 2.0.0 line-of-release @sebastianmalysa-wf @maxwellpeterson-wf @corwinsheahan-wf @evanweible-wf @greglittlefield-wf

aaronlademann-wf added a commit that referenced this pull request Sep 7, 2018
This reverts commit 0a4708a, reversing
changes made to 1827ad8.
@aaronlademann-wf aaronlademann-wf mentioned this pull request Sep 7, 2018
@aaronlademann-wf aaronlademann-wf restored the analyzer-version branch September 7, 2018 22:32
aaronlademann-wf added a commit that referenced this pull request Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants