Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #171 #180

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Revert #171 #180

merged 3 commits into from
Sep 7, 2018

Conversation

aaronlademann-wf
Copy link
Contributor

This reverts commit 0a4708a, reversing
changes made to 1827ad8 / #171

This revert is happening since it is causing 15+ minute pub get run times using the Dart 1.x version solver. These changes will be re-pr'd against the 2.0.0-dev branch.


FYA: @greglittlefield-wf @maxwellpeterson-wf

This reverts commit 0a4708a, reversing
changes made to 1827ad8.
@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner September 7, 2018 22:29
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          34       34           
  Lines        1612     1612           
=======================================
  Hits         1523     1523           
  Misses         89       89

@aaronlademann-wf
Copy link
Contributor Author

@Workiva/release-management-pp

@aaronlademann-wf aaronlademann-wf merged commit 645278b into master Sep 7, 2018
@aaronlademann-wf aaronlademann-wf deleted the revert-171 branch September 7, 2018 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants