Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak version ranges to allow pub get in Dart 2 #181

Closed
wants to merge 2 commits into from

Conversation

aaronlademann-wf
Copy link
Contributor

This was originally merged into master via #171. This PR merely merges those changes into our 2.0.0-dev branch.

Ultimate problem:

over_react specifies some maximum ranges to prevent Dart 2 resolutions.
The sdk 'environment' range should limit this for us.

How it was fixed:

Expand version ranges on analyzer, built_value, and quiver

Testing suggestions:

CI passes


FYA: @greglittlefield-wf @maxwellpeterson-wf

# Conflicts:
#	.travis.yml
#	Dockerfile
#	pubspec.yaml
#	tool/dev.dart
@aviary3-wk
Copy link

aviary3-wk commented Sep 7, 2018

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf added the dart2 PRs targeting our effort to get to Dart SDK 2.0 compatibility label Sep 7, 2018
@aaronlademann-wf aaronlademann-wf added this to the 2.0.0 milestone Sep 7, 2018
@corwinsheahan-wf
Copy link
Contributor

done as part of #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dependencies dart2 PRs targeting our effort to get to Dart SDK 2.0 compatibility Merge Requirements Unmet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants