Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BlockPreviews from axe-core tests. #26527

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Conversation

Addison-Stavlo
Copy link
Contributor

Description

Hopes to resolve e2e test failures from the error "Failed to inject axe-core into frame (about:blank)" by disabling BlockPreviews from axe tests. This seems to make sense as Block Previews are disabled from interaction and are used as images, so they should not make sense for a11y tests in the first place.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Oct 28, 2020

Size Change: 0 B

Total Size: 1.21 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.78 kB 0 B
build/api-fetch/index.js 3.45 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.94 kB 0 B
build/block-library/editor.css 8.94 kB 0 B
build/block-library/index.js 146 kB 0 B
build/block-library/style-rtl.css 7.82 kB 0 B
build/block-library/style.css 7.82 kB 0 B
build/block-library/theme-rtl.css 837 B 0 B
build/block-library/theme.css 838 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 172 kB 0 B
build/components/style-rtl.css 15.2 kB 0 B
build/components/style.css 15.2 kB 0 B
build/compose/index.js 9.81 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/data-controls/index.js 772 B 0 B
build/data/index.js 8.77 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.46 kB 0 B
build/edit-navigation/index.js 11.2 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.36 kB 0 B
build/edit-site/index.js 22 kB 0 B
build/edit-site/style-rtl.css 3.84 kB 0 B
build/edit-site/style.css 3.83 kB 0 B
build/edit-widgets/index.js 26.4 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 43.1 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 7.7 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.34 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13.2 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@talldan
Copy link
Contributor

talldan commented Oct 28, 2020

Unfortunately it failed on the last run with the Failed to inject axe-core into frame (about:blank) error. It seems like a few folks have run into this on the axe repos:

Unfortunately both issues are currently closed.

@talldan
Copy link
Contributor

talldan commented Oct 28, 2020

I tried a different way on #26535.

@Addison-Stavlo Addison-Stavlo force-pushed the fix/axe-core-e2e-failures branch from f2067df to a7945f7 Compare October 28, 2020 17:16
@Addison-Stavlo
Copy link
Contributor Author

Unfortunately it failed on the last run with the Failed to inject axe-core into frame (about:blank) error.

I wonder if giving the selector for the content instead of the container changes anything. Running this out of curiousity.

I tried a different way on #26535.

Great! I like where that one is going, good catch with the undocumented disableFrame function.

@Addison-Stavlo
Copy link
Contributor Author

Addison-Stavlo commented Oct 28, 2020

The template-parts test has passed 3x in a row after a7945f7 . I wonder if this would make sense as an alternative (or addition) to what is being done in #26535.

@Addison-Stavlo Addison-Stavlo added [Package] E2E Tests /packages/e2e-tests [Tool] Jest Puppeteer aXe /packages/jest-puppeteer-axe [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. and removed [Tool] Jest Puppeteer aXe /packages/jest-puppeteer-axe labels Oct 28, 2020
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's go with this as it's much simpler than #26535.

@talldan talldan merged commit 3f535db into master Oct 29, 2020
@talldan talldan deleted the fix/axe-core-e2e-failures branch October 29, 2020 02:56
@github-actions github-actions bot added this to the Gutenberg 9.3 milestone Oct 29, 2020
@gziolo
Copy link
Member

gziolo commented Oct 29, 2020

It still doesn't resolve the issue fully:
https://github.com/WordPress/gutenberg/runs/1325431331?check_suite_focus=true

Screen Shot 2020-10-29 at 11 55 25

@Addison-Stavlo
Copy link
Contributor Author

It still doesn't resolve the issue fully:

Oof.. the intermittency is a killer. Should we revert this?

@gziolo
Copy link
Member

gziolo commented Oct 29, 2020

It feels like it helped a bit do it's fine to keep it until there's a better fix discovered.

@talldan
Copy link
Contributor

talldan commented Oct 30, 2020

I'll revisit #26535.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants