-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable BlockPreviews from axe-core tests. #26527
Conversation
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
Unfortunately it failed on the last run with the
Unfortunately both issues are currently closed. |
I tried a different way on #26535. |
f2067df
to
a7945f7
Compare
I wonder if giving the selector for the content instead of the container changes anything. Running this out of curiousity.
Great! I like where that one is going, good catch with the undocumented |
The template-parts test has passed 3x in a row after a7945f7 . I wonder if this would make sense as an alternative (or addition) to what is being done in #26535. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, let's go with this as it's much simpler than #26535.
It still doesn't resolve the issue fully: |
Oof.. the intermittency is a killer. Should we revert this? |
It feels like it helped a bit do it's fine to keep it until there's a better fix discovered. |
I'll revisit #26535. |
Description
Hopes to resolve e2e test failures from the error
"Failed to inject axe-core into frame (about:blank)"
by disabling BlockPreviews from axe tests. This seems to make sense as Block Previews are disabled from interaction and are used as images, so they should not make sense for a11y tests in the first place.How has this been tested?
Screenshots
Types of changes
Checklist: