-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to convert a template part to regular blocks. #26488
Add the option to convert a template part to regular blocks. #26488
Conversation
Size Change: +128 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
I don't find the "Convert to regular blocks" phrasing super intuitive, especially for this case, since blocks within a template part are regular blocks. Perhaps something like "Detach blocks from template" or "Ungroup blocks from template" could make more sense. |
Im happy going with whatever naming makes sense. Updated to "Detach blocks from template part." for now.
Similarly, blocks within a reusable block are regular blocks? So the phrasing there may not be intuitive as well 🤔 . |
d807861
to
8e07a5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well in my testing. Code looks good, as far as I understand what's going on :)
7b183d0
to
62d36e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with groups and all kinds of blocks and it all works well!
62d36e1
to
505e9f5
Compare
Description
Recently we added the ability to convert selected blocks into a Template Part (#20445), modeled after the reusable blocks flow:
Reusable blocks also has the option to convert back to regular blocks:
Similarly, we could the option to convert a single template part to regular blocks:
This PR enables this functionality. Is this something that makes sense for the Template Part flow? cc @mtias
How has this been tested?
Select a template part and try to convert it to standard blocks as shown in the screenshot above. Verify this works as expected.
Also verify the 'convert to template part' flow continues to work as expected.
Screenshots
Types of changes
Checklist: