Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to convert a template part to regular blocks. #26488

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented Oct 27, 2020

Description

Recently we added the ability to convert selected blocks into a Template Part (#20445), modeled after the reusable blocks flow:

Screen Shot 2020-10-26 at 9 12 36 PM

Reusable blocks also has the option to convert back to regular blocks:

Screen Shot 2020-10-26 at 9 11 22 PM

Similarly, we could the option to convert a single template part to regular blocks:

Screen Shot 2020-10-26 at 9 12 14 PM

This PR enables this functionality. Is this something that makes sense for the Template Part flow? cc @mtias

How has this been tested?

Select a template part and try to convert it to standard blocks as shown in the screenshot above. Verify this works as expected.
Also verify the 'convert to template part' flow continues to work as expected.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Addison-Stavlo Addison-Stavlo self-assigned this Oct 27, 2020
@Addison-Stavlo Addison-Stavlo changed the title Add the option to convert a template part to standard blocks. Add the option to convert a template part to regular blocks. Oct 27, 2020
@github-actions
Copy link

github-actions bot commented Oct 27, 2020

Size Change: +128 B (0%)

Total Size: 1.21 MB

Filename Size Change
build/edit-site/index.js 22.1 kB +128 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.78 kB 0 B
build/api-fetch/index.js 3.45 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.94 kB 0 B
build/block-library/editor.css 8.94 kB 0 B
build/block-library/index.js 146 kB 0 B
build/block-library/style-rtl.css 7.82 kB 0 B
build/block-library/style.css 7.82 kB 0 B
build/block-library/theme-rtl.css 837 B 0 B
build/block-library/theme.css 838 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 172 kB 0 B
build/components/style-rtl.css 15.2 kB 0 B
build/components/style.css 15.2 kB 0 B
build/compose/index.js 9.81 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/data-controls/index.js 772 B 0 B
build/data/index.js 8.77 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.46 kB 0 B
build/edit-navigation/index.js 11.2 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.36 kB 0 B
build/edit-site/style-rtl.css 3.84 kB 0 B
build/edit-site/style.css 3.83 kB 0 B
build/edit-widgets/index.js 26.4 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 43.1 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 7.7 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.34 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13.2 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@mtias
Copy link
Member

mtias commented Oct 27, 2020

I don't find the "Convert to regular blocks" phrasing super intuitive, especially for this case, since blocks within a template part are regular blocks. Perhaps something like "Detach blocks from template" or "Ungroup blocks from template" could make more sense.

@Addison-Stavlo
Copy link
Contributor Author

Perhaps something like "Detach blocks from template" or "Ungroup blocks from template" could make more sense.

Im happy going with whatever naming makes sense. Updated to "Detach blocks from template part." for now.

I don't find the "Convert to regular blocks" phrasing super intuitive, especially for this case, since blocks within a template part are regular blocks.

Similarly, blocks within a reusable block are regular blocks? So the phrasing there may not be intuitive as well 🤔 .

@Addison-Stavlo Addison-Stavlo force-pushed the try/convert-template-part-to-standard-blocks branch from d807861 to 8e07a5a Compare October 27, 2020 18:03
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in my testing. Code looks good, as far as I understand what's going on :)

@Addison-Stavlo Addison-Stavlo force-pushed the try/convert-template-part-to-standard-blocks branch from 7b183d0 to 62d36e1 Compare October 27, 2020 21:59
Copy link
Member

@david-szabo97 david-szabo97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with groups and all kinds of blocks and it all works well!

@Addison-Stavlo Addison-Stavlo force-pushed the try/convert-template-part-to-standard-blocks branch from 62d36e1 to 505e9f5 Compare October 28, 2020 17:13
@Addison-Stavlo
Copy link
Contributor Author

Note the failing template-part e2e is an unrelated problem with axe and is being addressed in #26535 or #26527

@Addison-Stavlo Addison-Stavlo merged commit 739fe06 into master Oct 28, 2020
@Addison-Stavlo Addison-Stavlo deleted the try/convert-template-part-to-standard-blocks branch October 28, 2020 18:01
@github-actions github-actions bot added this to the Gutenberg 9.3 milestone Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants