-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore error when axe core fails to inject into blank iframes #26590
Conversation
Size Change: +208 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! A bit disappointing and surprising that the approach in #26535 didn't work out.
Axe itself won't fail tests when this injection fails, so it seems we're being stricter than Axe
Interesting! It seems to make sense to not fail our tests as a result of this axe error. Especially since all other approaches seem to not work out. Il re-run the tests a few times and see if its consistent.
🤦♀️ - It seems to still fail on the error... 🤷♀️
|
@Addison-Stavlo 🤔 I'm guessing |
Nope, that didn't work either. I think I have to call it quits there. I've spent quite a bit of my time looking into these issues. It's about time that others on the project stepped up and helped. |
Description
Previously #26527, #26535
Axe core tests fail intermittently:
This occurs when axe attempts to inject scripts into iframes created by the react-resize-aware utility in the
useResizeObserver
hook, mostly when tests briefly interact with block previews.This PR adds the error message to our list of exceptions for things that will fail tests.
Axe itself won't fail tests when this injection fails, so it seems we're being stricter than Axe:
https://github.com/dequelabs/axe-core-npm/blob/1f06cb67e2bbbf1922fd9d2e6bcee74f092cfa1c/packages/puppeteer/src/axePuppeteer.ts#L67-L69
How has this been tested?
CI tests should regularly pass.