Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some block features are rendered with invisible ink with dark backgrounds. #26479

Closed
bph opened this issue Oct 26, 2020 · 1 comment · Fixed by #26483
Closed

Some block features are rendered with invisible ink with dark backgrounds. #26479

bph opened this issue Oct 26, 2020 · 1 comment · Fixed by #26483
Assignees
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@bph
Copy link
Contributor

bph commented Oct 26, 2020

This is just an example for the Columns block:

In this video you see me trying to drag and drop a paragraph into a columns block that's above the paragraph, with two 50/50 columns.

When I start dragging the paragraph to a column, I hardly can see 'where I am going'. Although there is a light outline of the paragraph at the beginning, the column block doesn't have a light outline and the blue on black is barely invisible.
Also, the blue landing zone color is barely visible on this dark background.

In the example I use Twenty-Twenty-one.

Steps to reproduce the behavior:

  1. Use a dark default color - I used #303030
  2. Create a columns block with two columns
  3. Create a paragraph block
  4. Drag & drop the paragraph block into one of the columns.

Expected behavior
I would expect the block outlines to switch to a light color on dark background.

Screenshots
https://recordit.co/rwoBomnXTU

Editor version:
WordPress version: trunk (5.6. beta someting]
Gutenberg zip from Master 10/23/20]

Desktop (please complete the following information):

  • OS: OSX 10.14.6
  • Browser Google Chrome
  • Version 86.0.4240.80

I first filed this with TT1 repo, but it seems to be an editor bug. I also tested it with the Twenty-Twenty theme and saw the same problem.

There are related issue on this repo (as @carolinan found)

@bph
Copy link
Contributor Author

bph commented Oct 26, 2020

Looking at other core blocks....

Verse
I selected the verse block but did not see what I was typing. Once I highlighted it, I saw there is some text in the editor.
https://recordit.co/CZTnaCTuoh

Gallery
In general, it works, except for the Caption placeholder

Screen Shot 2020-10-26 at 5 34 58 PM

Table block
https://recordit.co/HEgrgPiBsp
Screen Shot 2020-10-26 at 6 20 34 PM

@bph bph added [Status] Not Applicable Issue outside Gutenberg, is not a bug, or is a support request. [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts and removed [Status] Not Applicable Issue outside Gutenberg, is not a bug, or is a support request. labels Oct 26, 2020
mapk added a commit that referenced this issue Oct 26, 2020
…Table blocks. Adds a dark mode color for the block appender button.
@mapk mapk mentioned this issue Oct 26, 2020
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 26, 2020
aristath pushed a commit that referenced this issue Oct 27, 2020
…Table blocks. Adds a dark mode color for the block appender button. (#26483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants