-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode UI updates #26483
Dark mode UI updates #26483
Conversation
…Table blocks. Adds a dark mode color for the block appender button.
Size Change: +151 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Looks good, thank you! Pet peeve: I try to avoid the term "dark mode" for this stuff, as it's technically independant of a dark mode feature that I could see landing in the block editor at some point. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with Twenty-twenty-one and Twenty-Twenty. It looks so much better now. 👏
The failing tests have nothing to do with this PR so this is safe to merge 👍 |
Fixes #26479.
Provides a dark mode color for caption placeholders as seen in Gallery and Table blocks.
Adds a dark mode color for the block appender button as seen in the Columns block.
How has this been tested?
Tested locally.
Screenshots
Gutenberg Starter Theme
Twenty Twenty One
I'm not sure why the Columns block appender buttons and the Verse block's placeholder text doesn't show correctly in this theme. Anyone have any ideas?
Types of changes
CSS changes.
Checklist: