-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dark mode to the post title #25796
Conversation
Size Change: +37 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. This works well in my testing, using the Gutenberg Starter Theme's dark mode option:
Before | After |
---|---|
This duplicates a chunk of code, so we might want to create a mixin.
This would be good to try in a followup PR if you have the time. But I think what we have here is totally fine.
Description
Dark mode switches the placeholders to be a light color. This adds code so that post title placeholders also are light in dark mode.
This duplicates a chunk of code, so we might want to create a mixin.
How has this been tested?
add_theme_support( 'dark-editor-style' );
)Screenshots
Before
After
Types of changes
Checklist: