Typo in desc, and size mixin updates #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although, this looks like it is going away in version 5.
If you have 2 of the same values in size mixin, doesn't it compile to height: 100% 100%; width: 100% 100%; http://www.sassmeister.com/gist/38c909c75a0474e6b587b849f2beb800
|
Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
sizemixin compiles with duplicate values if the w and h are the same when I used their size mixin from master:http://www.sassmeister.com/gist/38c909c75a0474e6b587b849f2beb800
But I also see on your CodePen demo of hero that it isn't doing that. I believe they are deprecating this mixin in V5 anyway, but thought this might be helpful in the meantime.