Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in desc, and size mixin updates #253

Merged
merged 5 commits into from
Mar 20, 2017
Merged

Typo in desc, and size mixin updates #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9efe64f
fix typo
stacyk Mar 19, 2017
601629f
Remove height if using size mixin
stacyk Mar 19, 2017
3db9c63
Only 1 value if they are the same for size mixin
stacyk Mar 19, 2017
d279d0b
dup sizes - I'd amend but I am working in browser
stacyk Mar 19, 2017
b84a396
Dup Sizes in commented out code
stacyk Mar 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions assets/sass/base/_accessibility.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@

// Hide text meant only for screen readers
.screen-reader-text {
@include size(rem(1) auto);
@include size(rem(1));

clip: rect(rem(1), rem(1), rem(1), rem(1));
height: rem(1);
overflow: hidden;
position: absolute;
white-space: nowrap; // do not smuch text in screen readers
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/base/_media.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ img {

// Video as background
.video-as-background {
@include size(100% 100%);
@include size(100%);

display: block;
object-fit: cover;
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/modules/_hero.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// Transparent overlay (optional).
&::after {
@include position(absolute, 0 0 null null);
@include size(100% 100%);
@include size(100%);

background-color: rgba($color-black, 0.6);
content: "";
Expand All @@ -24,7 +24,7 @@
// &:after {
// @include linear-gradient(to bottom, rgba($color-black, 0) 0%, rgba($color-black, 0.50) 50%);
// @include position(absolute, 0 0 null null);
// @include size(100% 100%);
// @include size(100%);

// content: '';
// z-index: 2;
Expand Down
2 changes: 1 addition & 1 deletion inc/acf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* Custom ACF functions.
*
* A place to custom funcdtionality related to Advanced Custom Fields.
* A place to custom functionality related to Advanced Custom Fields.
*
* @package _s
*/
Expand Down