Skip to content

Commit

Permalink
Typo in desc, and size mixin updates (#253)
Browse files Browse the repository at this point in the history
* fix typo

* Remove height if using size mixin

Although, this looks like it is going away in version 5.

* Only 1 value if they are the same for size mixin

If you have 2 of the same values in size mixin, doesn't it compile to height: 100% 100%; width: 100% 100%;

http://www.sassmeister.com/gist/38c909c75a0474e6b587b849f2beb800

* dup sizes - I'd amend but I am working in browser

* Dup Sizes in commented out code
  • Loading branch information
stacyk authored and gregrickaby committed Mar 20, 2017
1 parent d2511ca commit 7d1beae
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions assets/sass/base/_accessibility.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@

// Hide text meant only for screen readers
.screen-reader-text {
@include size(rem(1) auto);
@include size(rem(1));

clip: rect(rem(1), rem(1), rem(1), rem(1));
height: rem(1);
overflow: hidden;
position: absolute;
white-space: nowrap; // do not smuch text in screen readers
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/base/_media.scss
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ img {

// Video as background
.video-as-background {
@include size(100% 100%);
@include size(100%);

display: block;
object-fit: cover;
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/modules/_hero.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// Transparent overlay (optional).
&::after {
@include position(absolute, 0 0 null null);
@include size(100% 100%);
@include size(100%);

background-color: rgba($color-black, 0.6);
content: "";
Expand All @@ -24,7 +24,7 @@
// &:after {
// @include linear-gradient(to bottom, rgba($color-black, 0) 0%, rgba($color-black, 0.50) 50%);
// @include position(absolute, 0 0 null null);
// @include size(100% 100%);
// @include size(100%);

// content: '';
// z-index: 2;
Expand Down
2 changes: 1 addition & 1 deletion inc/acf.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* Custom ACF functions.
*
* A place to custom funcdtionality related to Advanced Custom Fields.
* A place to custom functionality related to Advanced Custom Fields.
*
* @package _s
*/
Expand Down

0 comments on commit 7d1beae

Please sign in to comment.