make navigator update "focus-tiddler" field ... #3590

BurningTreeC · 2018-11-28T10:37:01Z

... when cancelling, deleting, closing

a findAdjacentTiddler function handles which tiddler-title gets written if the closed/cancelled/deleted tiddler is the one in the "current-tiddler" field

the next tiddler in the river if it's present
else the previous one
if there's no next/previous tiddler nothing is changed (the last one remains in "current-tiddler")

with this, every action that changes the story list sets the current-tiddler field if the surrounding navigator widget has a history tiddler defined

... when cancelling, deleting, closing a `findAdjacentTiddler` function handles which tiddler-title gets written if the closed/cancelled/deleted tiddler is the one in the "current-tiddler" field - the next tiddler in the river if it's present - else the previous one - if there's no next/previous tiddler nothing is changed (the last one remains in "current-tiddler") with this, every action that changes the story list sets the `current-tiddler` field if the surrounding navigator widget has a history tiddler defined

Jermolene · 2018-11-28T10:51:21Z

Hi @BurningTreeC looks good at a brief glance. I'd like to change current-tiddler to focus-tiddler, though, to avoid confusion with the existing currentTiddler variable.

BurningTreeC · 2018-11-28T11:01:01Z

I'd like to change current-tiddler to focus-tiddler, though, to avoid confusion with the existing currentTiddler variable

Hi @Jermolene, that's ok, I'll do that.

I've added a "focus-tiddler" stylesheet which uses bits from #3572 ... a setting in the controlpanel enables showing the FocusTiddler with a thin border or alternative user-defined styles, but that uses CSS.escape

and set focus-tiddler when current-tiddler field gets set

BurningTreeC · 2018-11-28T15:36:49Z

removed the stylesheet
made the story-startup set focus-tiddler, too

BurningTreeC · 2018-11-29T09:25:20Z

I'm done here

BurningTreeC · 2019-01-30T09:43:54Z

Hi @Jermolene , I think this would be a good feature to have. How do you want to proceed with this?

It would be useful if we could also access the previously navigated tiddler in a simple way, maybe through populating a navigation-history list

BurningTreeC · 2019-03-12T12:12:50Z

Hi @Jermolene , I've resolved the merge conflict. What should we do with this?

Jermolene · 2019-03-12T12:16:55Z

Hi @BurningTreeC there's another ticket where we've been talking about preserving the focus over the refresh cycle. Perhaps we should review that work before we merge this PR. The motivation being that if we had a robust way to preserve the focus then we should be able to use the browser focus mechanism to keep track of the currently selected tiddler.

Jermolene · 2019-03-12T12:17:53Z

(I also realised that we probably shouldn't re-use $:/History for this, because it's nothing to do with navigation. If anything, the focus storage could be part of $:/StoryList).

BurningTreeC · 2019-03-12T12:26:44Z

@Jermolene , I agree with both

I don't have this in mind for the focus-preserving within inputs
it's really more for navigating the story with keyboard shortcuts

this can allow to set focus to an input of the navigated tiddler in the end, too, but that's a (positive) side-effect

Jermolene · 2019-03-12T12:31:51Z

I don't have this in mind for the focus-preserving within inputs it's really more for navigating the story with keyboard shortcuts

But if we had focus preservation then couldn't we use the browsers own focus handling to manage the current tiddler? (the current tiddler would be the one containing the focus, plus we'd make the tiddler frame be focusable).

pmario · 2019-03-12T12:41:34Z

IMO We have to keep in mind, that there can be several $:/StoryList's!!

Jermolene · 2019-03-12T12:42:52Z

IMO We have to keep in mind, that there can be several $:/StoryList's!!

Indeed, I should have spelled out that I meant the tiddler named in the story attribute of the navigator widget.

BurningTreeC · 2019-03-12T12:49:07Z

But if we had focus preservation then couldn't we use the browsers own focus handling to manage the current tiddler? (the current tiddler would be the one containing the focus, plus we'd make the tiddler frame be focusable).

that's a good point

BurningTreeC · 2019-03-12T12:49:40Z

yes, the storylists have to be taken into account, you're right

at startup, too

BurningTreeC · 2019-07-04T07:33:08Z

opening this again, because of #4061

pmario · 2019-07-04T09:43:52Z

@BurningTreeC

fix toc and prepare for link highlighting if element is selected #3975 will offer the same possibilities, without the need to modify navigator.

see the video: https://www.youtube.com/watch?v=iaevaODdKyA

The PR 3975 contains a stripped down version of the video. ... but it prepares everything that the focus-tiddler plugin will work in the future.

BurningTreeC · 2019-07-04T09:44:58Z

closing in favor of #3975

pmario · 2019-07-04T09:45:02Z

In the future the "storyview.js" will need to be updated, because the storyview is the only instance, which can really tell which tiddler is "on-top" aka "focused"

BurningTreeC · 2019-07-04T09:47:02Z

@pmario,

but it prepares everything that the focus-tiddler plugin will work in the future.

I'm not worried about the plugin... I'm just interested where the "viewed tiddler" is stored :)

BurningTreeC · 2019-07-13T07:56:01Z

@pmario I've reopened this PR

@Jermolene is it possible to have this (or similar) for 5.1.20?

pmario · 2019-07-13T11:54:58Z

@BurningTreeC ... This is way to complicated. ... The story.js has to do the job and it only needs to change 1 line of code and make it 2 for readability.

BurningTreeC · 2019-07-13T11:59:25Z

@pmario

The story.js has to do the job and it only needs to change 1 line of code and make it 2 for readability.

do you PR?

pmario · 2019-07-13T12:51:02Z

I can try, but it was rejected, as included in the toc improvements.

BurningTreeC · 2019-07-13T15:23:44Z

@pmario but it keeps track of closing, deleting and canceling, too

pmario · 2019-07-14T08:41:12Z

core/modules/widgets/navigator.js

@@ -126,6 +126,16 @@ fromPageRect: page coordinates of the origin of the navigation
 */
 NavigatorWidget.prototype.addToHistory = function(title,fromPageRect) {
 	this.wiki.addToHistory(title,fromPageRect,this.historyTitle);
+	this.wiki.setText(this.historyTitle,"focus-tiddler",undefined,title);


This probably causes an unneeded re-rendering of the story river, since you modify the history list 2 times. Modifying history list needs to be atomic write action

Just to clarify that the async nature of the refresh mechanism prevents that from happening: these two writes will just add the $:/HistoryList to the list of changes queued up for the next refresh, which actually occurs after an async timeout.

BurningTreeC · 2019-08-03T09:39:18Z

I'm reopening this because it would be great to have for 5.1.20

BurningTreeC · 2019-08-04T05:09:10Z

closing in favor of a new, cleaner attempt

BurningTreeC · 2019-08-04T06:11:08Z

see #4156

BurningTreeC added 4 commits November 28, 2018 12:07

change current-tiddler to focus-tiddler

bd7eb03

and set focus-tiddler when current-tiddler field gets set

add focus-tiddler css

4c87434

typo

93fa0b5

remove focus-tiddler css

1d7ecb4

BurningTreeC changed the title ~~make navigator update "current-tiddler" field ...~~ make navigator update "focus-tiddler" field ... Nov 28, 2018

Update story.js

f98e3aa

Update navigator.js

9e8ea0f

BurningTreeC mentioned this pull request Nov 28, 2018

fix sticky titles - performant version #3572

Closed

Jermolene mentioned this pull request Nov 29, 2018

[UI] add selectable tags- and search-dropdown #3565

Closed

Jermolene added the v5.1.20 Planned for v5.1.20 label Nov 29, 2018

Update navigator.js

50dd7be

Merge branch 'master' into patch-61

c3389c0

BurningTreeC mentioned this pull request Mar 12, 2019

CSS.escape as startup module - seems to work #3574

Merged

Simon Huber added 2 commits March 14, 2019 13:21

use storylist tiddler instead of historylist

fd224b5

use storylist tiddler when opening default tiddlers ...

ea022af

at startup, too

BurningTreeC closed this Mar 14, 2019

BurningTreeC deleted the patch-61 branch June 23, 2019 13:30

BurningTreeC restored the patch-61 branch July 4, 2019 07:32

BurningTreeC reopened this Jul 4, 2019

BurningTreeC mentioned this pull request Jul 4, 2019

every navigation should update "viewed-tiddler" #4061

Closed

BurningTreeC closed this Jul 4, 2019

BurningTreeC reopened this Jul 13, 2019

BurningTreeC closed this Jul 14, 2019

pmario reviewed Jul 14, 2019

View reviewed changes

BurningTreeC reopened this Aug 3, 2019

BurningTreeC closed this Aug 4, 2019

BurningTreeC deleted the patch-61 branch July 20, 2020 06:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make navigator update "focus-tiddler" field ... #3590

make navigator update "focus-tiddler" field ... #3590

BurningTreeC commented Nov 28, 2018

Jermolene commented Nov 28, 2018

BurningTreeC commented Nov 28, 2018

BurningTreeC commented Nov 28, 2018

BurningTreeC commented Nov 29, 2018

BurningTreeC commented Jan 30, 2019

BurningTreeC commented Mar 12, 2019

Jermolene commented Mar 12, 2019

Jermolene commented Mar 12, 2019

BurningTreeC commented Mar 12, 2019

Jermolene commented Mar 12, 2019

pmario commented Mar 12, 2019

Jermolene commented Mar 12, 2019

BurningTreeC commented Mar 12, 2019

BurningTreeC commented Mar 12, 2019

BurningTreeC commented Jul 4, 2019

pmario commented Jul 4, 2019

BurningTreeC commented Jul 4, 2019

pmario commented Jul 4, 2019

BurningTreeC commented Jul 4, 2019

BurningTreeC commented Jul 13, 2019

pmario commented Jul 13, 2019

BurningTreeC commented Jul 13, 2019

pmario commented Jul 13, 2019

BurningTreeC commented Jul 13, 2019

pmario Jul 14, 2019

Jermolene Jul 14, 2019

BurningTreeC commented Aug 3, 2019

BurningTreeC commented Aug 4, 2019

BurningTreeC commented Aug 4, 2019

make navigator update "focus-tiddler" field ... #3590

make navigator update "focus-tiddler" field ... #3590

Conversation

BurningTreeC commented Nov 28, 2018

Jermolene commented Nov 28, 2018

BurningTreeC commented Nov 28, 2018

BurningTreeC commented Nov 28, 2018

BurningTreeC commented Nov 29, 2018

BurningTreeC commented Jan 30, 2019

BurningTreeC commented Mar 12, 2019

Jermolene commented Mar 12, 2019

Jermolene commented Mar 12, 2019

BurningTreeC commented Mar 12, 2019

Jermolene commented Mar 12, 2019

pmario commented Mar 12, 2019

Jermolene commented Mar 12, 2019

BurningTreeC commented Mar 12, 2019

BurningTreeC commented Mar 12, 2019

BurningTreeC commented Jul 4, 2019

pmario commented Jul 4, 2019

BurningTreeC commented Jul 4, 2019

pmario commented Jul 4, 2019

BurningTreeC commented Jul 4, 2019

BurningTreeC commented Jul 13, 2019

pmario commented Jul 13, 2019

BurningTreeC commented Jul 13, 2019

pmario commented Jul 13, 2019

BurningTreeC commented Jul 13, 2019

pmario Jul 14, 2019

Choose a reason for hiding this comment

Jermolene Jul 14, 2019

Choose a reason for hiding this comment

BurningTreeC commented Aug 3, 2019

BurningTreeC commented Aug 4, 2019

BurningTreeC commented Aug 4, 2019