Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS.escape as startup module - seems to work #3574

Merged
merged 9 commits into from
Jun 26, 2019

Conversation

BurningTreeC
Copy link
Contributor

No description provided.

@BurningTreeC BurningTreeC changed the title CSS.escape as polyfill module - Note: don't know what I'm doing CSS.escape as polyfill module - Note: not that sure if it's done correctly Nov 27, 2018
@Jermolene
Copy link
Member

Hi @BurningTreeC thinking about it more, perhaps the polyfill should just be a plain old startup module? that way polyfills can mark themselves for execution in the browser/node etc.

Am I right in thinking this is only needed for v5.1.18 if we merge #3572?

@BurningTreeC
Copy link
Contributor Author

Hi @Jermolene, yes startup module sounds better

Am I right in thinking this is only needed for v5.1.18 if we merge #3572?

If we want to mark a current-tiddler that's tracked through a field-value like in $:/HistoryList this would also be useful... #980 ... but yes, at the moment it's for #3572 only

@BurningTreeC
Copy link
Contributor Author

By the way, the tracking would be very easy, just a bit of filtering within the cancel-tiddler/delete-tiddler/close-tiddler buttons/actions, the rest is already handled by that current-tiddler field in $:/HistoryList

@Jermolene
Copy link
Member

Thanks @BurningTreeC

@BurningTreeC BurningTreeC changed the title CSS.escape as polyfill module - Note: not that sure if it's done correctly CSS.escape as startup module - seems to work Nov 28, 2018
@Jermolene Jermolene added the v5.1.20 Planned for v5.1.20 label Nov 29, 2018
@BurningTreeC
Copy link
Contributor Author

Hi @Jermolene , how do you want to proceed with this?

I tested this on an old firefox without CSS.escape support and it works

@BurningTreeC
Copy link
Contributor Author

Hi again @Jermolene ... this would be interesting if we add the option of storing the navigated tiddler somewhere, like in #3590 , possibly with an option in the controlpanel to a) enable storing the navigated tiddler and b) showing it emphasized

  1. would that be something to be considered for the core?

  2. i'm not sure if the way how I add this polyfill here is correct. it works on an old firefox that doesn't have CSS.escape (tested) and then gets support through this (tested, too). but I'm lacking knowledge about the crossbrowser way of adding this polyfill

@Jermolene
Copy link
Member

I'm hoping we can use the browser focus mechansim, and then we could style the visual appearance of tiddlers that contain the focus with CSS :focus-within.

@BurningTreeC
Copy link
Contributor Author

I'm hoping we can use the browser focus mechansim, and then we could style the visual appearance of tiddlers that contain the focus with CSS :focus-within.

... aahhh! now I get what you're up to!

yep, if that's doable, great! 👍

@BurningTreeC BurningTreeC deleted the patch-51 branch June 23, 2019 13:29
@BurningTreeC BurningTreeC restored the patch-51 branch June 25, 2019 11:02
@BurningTreeC BurningTreeC reopened this Jun 25, 2019
@BurningTreeC
Copy link
Contributor Author

Should we use this?

@Jermolene
Copy link
Member

Hi @BurningTreeC apologies, I'm working my way back through the email notifications and am seeing this after #3546. I'll go ahead and merge this.

@Jermolene Jermolene mentioned this pull request Jun 26, 2019
@Jermolene Jermolene merged commit e313b0b into TiddlyWiki:master Jun 26, 2019
@BurningTreeC BurningTreeC deleted the patch-51 branch July 13, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5.1.20 Planned for v5.1.20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants