-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sticky titles - performant version #3572
Conversation
Note that I've created the macro-sequences within the current Dynaview demo to make sure this doesn't cause notable performance drops |
... macro called `assign-css-to-data-tag`
We should probably do the same for the ... and apply the z-index to the tiddler-frame |
Or we make the popup mechanism also set the |
Hi @Jermolene , @pmario and @ALL ... one way would be to change all popup state titles so that they end with the title of the current tiddler, which would allow easy access to the tiddler-title and using the escapecss filter we set the z-indices like I'm doing here the other way would be not to change the state titles and to use the numhash filter (#3752) to identify the title of the tiddler that has an open popup the second way has a bigger performance cost but is more universal |
there would be a third way by setting a state tiddler to the title of the tiddler with the popup through the reveal widget -> if the currentTiddler variable is defined and it's a popup |
Hi @BurningTreeC I've just tried something else that seems like it might be promising. Try including this after the definition of
In my brief tests, this fixes all the dropdown overlapping problems. We'd need to find a way to programmatically generate those 100 definitions (and perhaps have a hidden setting so that users could increase the number). |
@Jermolene ... that's perfect 👍 ! |
Thanks @BurningTreeC! The maddening thing is that I can't see a way to generate those declarations without adding maths support to the core... (needless to say, one can't use calc() with z-index!). |
@Jermolene , there's a way ... |
|
I forgot the
|
this fixes the sticky-titles issue where more-popups are hidden by titles of following tiddlers in the story river
this PR has two advantages over #3567
calc()
- works in browsers that don't support calc, toomissing part to make this complete: a filter that correctly escapes characters that need to be escaped to be used within
data-tiddler-title
and that doesn't replace special characters, making the escaped string invalid (discussion here: #3546 )