-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Library to use integration settings (PP-11) #1281
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
- Coverage 89.95% 89.92% -0.04%
==========================================
Files 197 197
Lines 29149 28982 -167
Branches 6695 6631 -64
==========================================
- Hits 26220 26061 -159
+ Misses 1903 1900 -3
+ Partials 1026 1021 -5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really find anything at fault here. Just wondering why are the settings added to the Library model as opposed to using the IntegrationLibraryConfiguration Model without a parent.
I decided to add the settings directly to the library table because I didn't want to overload the |
7c5644b
to
54bed22
Compare
Description
Convert libraries to store their settings in a json column on the libraries table, rather then using configuration settings. See jira ticket PP-11.
Note: This PR is based on #1276 so that one should go in first.
Motivation and Context
This is part of the larger CM Config Settings epic: PP-4
How Has This Been Tested?
Checklist