Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared ODL API 🔥 #1276

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Remove shared ODL API 🔥 #1276

merged 3 commits into from
Jul 24, 2023

Conversation

jonathangreen
Copy link
Member

Description

This API intersects with the work in PP-11, because it uses library configuration settings to store the shared ODL configuration. We decided not to configure shared ODL on any of our circulation managers, instead relying on having any CM that needs to share a marketplace collection be on the same CM.

Motivation and Context

Since we are not using this code anywhere. It seems to make sense to remove it, instead of migrating it to use integration configurations.

How Has This Been Tested?

Running tests in CI.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (9bd0339) 89.98% compared to head (c953f97) 89.95%.

❗ Current head c953f97 differs from pull request most recent head 04cf9d7. Consider uploading reports for the commit 04cf9d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
- Coverage   89.98%   89.95%   -0.04%     
==========================================
  Files         198      197       -1     
  Lines       29225    29147      -78     
  Branches     6712     6694      -18     
==========================================
- Hits        26299    26218      -81     
- Misses       1901     1903       +2     
- Partials     1025     1026       +1     
Impacted Files Coverage Δ
api/admin/routes.py 94.94% <ø> (-0.06%) ⬇️
scripts.py 85.02% <ø> (ø)
api/admin/controller/__init__.py 86.47% <100.00%> (-0.36%) ⬇️
api/integration/registry/license_providers.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jonathangreen jonathangreen requested a review from a team July 18, 2023 16:33
@jonathangreen jonathangreen force-pushed the feature/remove-shared-odl branch from c953f97 to 04cf9d7 Compare July 19, 2023 13:59
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants