Remove SharedCollectionAPI and IntegrationClient 🔥 (PP-224) #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ade9cd5 to
db59d64
Compare
|
Rebased this, and resolved the conflicts that came in with #1288. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
- Coverage 89.87% 89.84% -0.03%
==========================================
Files 210 208 -2
Lines 28727 28542 -185
Branches 6567 6536 -31
==========================================
- Hits 25817 25643 -174
+ Misses 1896 1890 -6
+ Partials 1014 1009 -5
☔ View full report in Codecov by Sentry. |
| @@ -1409,197 +1409,6 @@ def active_licensepool_for(self, work): | |||
| return super().active_licensepool_for(work, library=self.library) | |||
|
|
|||
|
|
|||
| class SharedCollectionAnnotator(CirculationManagerAnnotator): | |||
There was a problem hiding this comment.
You just blew away days of work from the Annotator refactor 🥳
There was a problem hiding this comment.
@RishiDiwanTT that is great to hear! 🎉
Trying to save us time, and reduce cognitive overhead when trying to reason about the code it the big reason I've been trying to remove bits and pieces that are no longer used or needed.
db59d64 to
14a2f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we remove the following classes from the CM:
SharedCollectionAPIIntegrationClientThis involves a database migration to drop the
integration_clienttable. I did a quick query of the DBs on the Palace production servers to make sure that none of them have any entries in this table.JIRA: PP-224
Motivation and Context
This work was started in #1276 as part of the work on PP-11. However when working on a unrelated issue, I noticed that I had removed the "client" side of the Shared ODL integration, but I had failed to remove the "server" side.
Since there is no Shared ODL client anymore, this "server" code is effectively dead, and should also be removed.
How Has This Been Tested?
Checklist